fix(cloudflare): declare esbuild as runtime dependency - #1353
Open
uttkarsh-26 wants to merge 1 commit into
Open
Conversation
esbuild is imported at build time (bundle-server.ts, open-next/*) but was only in devDependencies. Consumers only got it via hoisting from @opennextjs/aws, which breaks under npm ci and when the hoist slot is claimed (e.g. vite optional peer). Add esbuild to dependencies (catalog) and add regression test. Fixes opennextjs#1339
🦋 Changeset detectedLatest commit: 8c34479 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Problem
@opennextjs/cloudflareimportsesbuildat build time (src/cli/build/bundle-server.ts,src/cli/build/open-next/*.ts) but declared it only indevDependencies. Consumers only resolved it via hoisting from@opennextjs/aws(0.25.4), which breaks when the hoist slot is claimed (e.g.@vitejs/plugin-reactoptional peer) and leavesnpm ciwithextraneous: true.Approach
esbuild: catalog:fromdevDependenciestodependenciesinpackages/cloudflare/package.json(catalog already^0.27.0).build-deps.spec.tsthat assertsdependencies.esbuildis defined (TDD: RED before fix, GREEN after).Tests
build-deps.spec.tsfails withexpected undefined to be definedbefore fix (1 failed, 342 passed).pnpm -C packages/cloudflare lint:checkandts:checkpass (import sorted).Risk
Low. No runtime behavior change; only ensures published package carries its build-time dependency.