Skip to content

escapeJs vulnerable to XSS #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhisy2506 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

escapeJs vulnerable to XSS #90

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abcf452
escapeJs vulnerable to XSS
Abhisy2506 Mar 19, 2026
9d589b4
Apply suggestion from @jwnasambu
Abhisy2506 Mar 19, 2026
4162b93
using replace instead of replaceAll
Abhisy2506 Mar 19, 2026
9026320
Missing semiclon
Abhisy2506 Mar 19, 2026
d22523b
Final build success commit
Abhisy2506 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions api/src/main/java/org/openmrs/ui/framework/UiUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,10 @@ public String escapeJs(String input) {
if (input == null) {
return null;
}

input = input.replaceAll("\\\\", "\\\\\\\\");
input = input.replaceAll("\n", "\\\\n");
input = input.replaceAll("\r", "\\\\r");
input = input.replaceAll("'", "\\\\'");
input = input.replaceAll("\"", "\\\\\"");
Comment thread
Abhisy2506 marked this conversation as resolved.
Outdated
return input;
Expand Down Expand Up @@ -683,11 +686,11 @@ public String getClientTimezone() {
public void setClientTimezone(String clientTimezone) {
try {
Context.addProxyPrivilege(PrivilegeConstants.EDIT_USERS);

String propertyName = Context.getAdministrationService()
.getGlobalProperty(UiFrameworkConstants.UP_CLIENT_TIMEZONE);
.getGlobalProperty(UiFrameworkConstants.UP_CLIENT_TIMEZONE);
Comment thread
Abhisy2506 marked this conversation as resolved.
String currentClientTimezone = Context.getAuthenticatedUser().getUserProperty(propertyName);

if (currentClientTimezone == null || !currentClientTimezone.equals(clientTimezone)) {
Context.getUserService().setUserProperty(Context.getAuthenticatedUser(), propertyName, clientTimezone);
}
Expand Down
22 changes: 22 additions & 0 deletions api/src/test/java/org/openmrs/ui/framework/UiUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,26 @@ public void urlBind_shouldProperlyBindPatientAndVisit() {

}

@Test
public void escapeJs_shouldEscapeBackslash() {
Assert.assertEquals("Foo \\\\", ui.escapeJs("Foo \\"));
}

@Test
public void escapeJs_shouldPreventXSSViaBackslashInjection() {
// exact payload from the bug report
String result = ui.escapeJs("Foo \\\"}];alert(0);[// Bar");
Assert.assertTrue(result.contains("\\\\")); // backslash must be doubled
Copy link
Copy Markdown

@jwnasambu jwnasambu Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly asserting only contains("\\"); is too weak and could pass even if the escaping regresses.
so please can either assert the exact expected escaped output for the full payload using Assert.assertEquals(expected, ui.escapeJs(input)), or
assert stronger conditions example that quotes are escaped and that the unescaped breakout sequence .

Copy link
Copy Markdown
Author

@Abhisy2506 Abhisy2506 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jwnasambu , thanks for reviewing it. Yeah i have added stricter assertion and you can now review that too.

}

@Test
public void escapeJs_shouldEscapeDoubleQuote() {
Assert.assertEquals("say \\\"hi\\\"", ui.escapeJs("say \"hi\""));
}

@Test
public void escapeJs_shouldReturnNullForNullInput() {
Assert.assertNull(ui.escapeJs(null));
}

}
Loading