Merge of r v1.8.x r into v1.9.x - #5415
Merged
Merged
Conversation
journal.forms import journal.logic which in turns import journal.forms logic is not used in journal.forms code, so it's a redundant import in any case This has not triggered any error just due to a lucky combination of factors 🙂
postgres_search() builds its final query by wrapping stringify_queryset() in Article.objects.raw(). stringify_queryset() returns SQL with all params already interpolated via cursor.mogrify(), so any '%' left in the string is literal (e.g. a search term like "50%"). raw() defaults params to () rather than None, so it re-runs %-formatting on that SQL and raised TypeError on terms containing '%'. Double the literal '%' so they survive that pass. Adds a regression test covering a '%'-bearing search term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.