Add unit tests for pkg/util/client/cache.go#270
Open
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
Open
Add unit tests for pkg/util/client/cache.go#270GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
Conversation
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
@ringtail , @chrisliu1995 will you rerun the workflow they seem to be unrelated to my pr , it will pass then. Also , review this whenever feasible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new test file, cache_test.go, to provide comprehensive unit test coverage for the custom cache implementation located in pkg/util/client/cache.go.
The new tests cover the following key areas:
Cache Creation: Verifies the NewCache function under various configurations, including default and custom schemes.
List Logic: Tests the branching logic of the internalCache.List method, ensuring it correctly handles the DisableDeepCopy option and the associated disable-no-deepcopy global flag.
Helper Functions: Validates helper utilities like isDisableDeepCopy and the no-op ApplyToList method to ensure complete coverage.