Skip to content

update pod labels when claiming#288

Merged
zmberg merged 1 commit intoopenkruise:masterfrom
furykerry:feat/claim-labeling
Apr 19, 2026
Merged

update pod labels when claiming#288
zmberg merged 1 commit intoopenkruise:masterfrom
furykerry:feat/claim-labeling

Conversation

@furykerry
Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.75%. Comparing base (dbd97a7) to head (e268ad5).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/servers/e2b/create.go 71.42% 1 Missing and 1 partial ⚠️
pkg/utils/inplaceupdate/inplace_update.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   67.20%   67.75%   +0.55%     
==========================================
  Files         112      112              
  Lines        7668     7689      +21     
==========================================
+ Hits         5153     5210      +57     
+ Misses       2221     2185      -36     
  Partials      294      294              
Flag Coverage Δ
unittests 67.75% <93.61%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@furykerry furykerry force-pushed the feat/claim-labeling branch 5 times, most recently from bebaf4c to c655764 Compare April 17, 2026 08:55
@kruise-bot kruise-bot added size/XL and removed size/M labels Apr 17, 2026
@furykerry furykerry force-pushed the feat/claim-labeling branch 6 times, most recently from 8ed9b9b to 3fad1e5 Compare April 17, 2026 12:56
Comment thread pkg/utils/inplaceupdate/inplace_update.go Fixed
Comment thread pkg/utils/inplaceupdate/inplace_update.go Fixed
Comment thread pkg/utils/inplaceupdate/inplace_update.go Fixed
@furykerry furykerry force-pushed the feat/claim-labeling branch 3 times, most recently from 896d2e9 to 063b5d8 Compare April 17, 2026 13:53
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
@furykerry furykerry force-pushed the feat/claim-labeling branch from 063b5d8 to e268ad5 Compare April 18, 2026 01:18
@zmberg
Copy link
Copy Markdown
Member

zmberg commented Apr 19, 2026

/lgtm
/approve

@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg zmberg merged commit 616acfd into openkruise:master Apr 19, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants