Skip to content

chore: add fmt-imports.sh and fmt imports#272

Merged
zmberg merged 1 commit intoopenkruise:masterfrom
PersistentJZH:feat/fmt-import
Apr 19, 2026
Merged

chore: add fmt-imports.sh and fmt imports#272
zmberg merged 1 commit intoopenkruise:masterfrom
PersistentJZH:feat/fmt-import

Conversation

@PersistentJZH
Copy link
Copy Markdown
Member

@PersistentJZH PersistentJZH commented Apr 14, 2026

Ⅰ. Describe what this PR does

  • add hack/fmt-imports.sh to fmt all imports
  • run make fmt-imports to verify

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.09%. Comparing base (567c69b) to head (926f901).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         112      112           
  Lines        7637     7637           
=======================================
  Hits         5124     5124           
  Misses       2218     2218           
  Partials      295      295           
Flag Coverage Δ
unittests 67.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
@zmberg
Copy link
Copy Markdown
Member

zmberg commented Apr 19, 2026

/lgtm
/approve

@zmberg zmberg merged commit da8890f into openkruise:master Apr 19, 2026
12 of 13 checks passed
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants