feat(sandbox-controller): support rolling update of sandboxset#256
Merged
zmberg merged 1 commit intoopenkruise:masterfrom Apr 22, 2026
Merged
feat(sandbox-controller): support rolling update of sandboxset#256zmberg merged 1 commit intoopenkruise:masterfrom
zmberg merged 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @BITLiutianyang! It looks like this is your first PR to openkruise/agents 🎉 |
b150acb to
800b202
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 66.27% 68.94% +2.66%
==========================================
Files 111 114 +3
Lines 7418 10319 +2901
==========================================
+ Hits 4916 7114 +2198
- Misses 2216 2901 +685
- Partials 286 304 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ac414e9 to
e4af614
Compare
c0b5361 to
af42f29
Compare
furykerry
reviewed
Apr 21, 2026
| if err != nil { | ||
| return err | ||
| } | ||
| // If cache is stale, fetch from API server directly |
af42f29 to
39fdfcf
Compare
furykerry
reviewed
Apr 22, 2026
39fdfcf to
bef58d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Support rolliing update of SandboxSet
Ⅱ. Does this pull request fix one issue?
fixes #76 .
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
This PR does not resolve all features mentioned in the issue. It is the first in a series of PRs.