to achieve dynamic remounting of CSI storage after a sandbox instance…#254
to achieve dynamic remounting of CSI storage after a sandbox instance…#254BH4AWS wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
|
|
||
| func NewSandboxControl(c client.Client, recorder record.EventRecorder, rl *RateLimiter) map[string]SandboxControl { | ||
| func NewSandboxControl(c client.Client, recorder record.EventRecorder, rl *RateLimiter, sandboxClient *clients.ClientSet, cache *sandboxcr.Cache) map[string]SandboxControl { |
There was a problem hiding this comment.
use funcArgs to contain all the parameters, e.g. client, recorder.
| originObj.Annotations = make(map[string]string) | ||
| } | ||
| _, hashWithoutImageAndResource := core.HashSandbox(box) | ||
| _, hashWithoutImageAndResource := sandboxcr.HashSandbox(box) |
There was a problem hiding this comment.
Move the HashSandbox to pkg/util ?
BH4AWS
force-pushed
the
feat/update_for_support_csi_mount_after_resuming
branch
2 times, most recently
from
7be9446 to
5bd8efa
Compare
… resumes from hibernation Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
BH4AWS
force-pushed
the
feat/update_for_support_csi_mount_after_resuming
branch
from
5bd8efa to
7c13c7f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 69.34% 71.48% +2.14%
==========================================
Files 112 117 +5
Lines 8126 8625 +499
==========================================
+ Hits 5635 6166 +531
+ Misses 2195 2150 -45
- Partials 296 309 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // hash using sandbox.spec.template without image and resources | ||
| tempClone := box.Spec.Template.DeepCopy() | ||
| for i := range tempClone.Spec.Containers { | ||
| container := &tempClone.Spec.Containers[i] |
There was a problem hiding this comment.
plz rebase the master, HashSandbox func is changed in the master
|
@BH4AWS: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
… resumes from hibernation
Ⅰ. Describe what this PR does
1\ In order to achieve dynamic remounting of CSI storage after a sandbox instance resumes from hibernation, some shared code logic needs to be adjusted in advance. The next PR will implement CSI storage remounting after hibernation and resume based on the object-oriented approach of SandboxClaim.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews