sandbox claim support PauseTime#243
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @CoodeRver! It looks like this is your first PR to openkruise/agents 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 66.34% 66.88% +0.54%
==========================================
Files 111 112 +1
Lines 7386 7508 +122
==========================================
+ Hits 4900 5022 +122
+ Misses 2201 2200 -1
- Partials 285 286 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if claim.Spec.ShutdownTime != nil { | ||
| opts.ShutdownTime = claim.Spec.ShutdownTime.Time | ||
| } | ||
| if claim.Spec.PauseTime != nil { |
CoodeRver
force-pushed
the
master
branch
2 times, most recently
from
a76ab7b to
fade933
Compare
CoodeRver
force-pushed
the
master
branch
3 times, most recently
from
7773d6a to
d00e4ef
Compare
Change-Id: Ifd6a9095a1febaba8aee97d916684bc4e86eefe7
Change-Id: I517ce7e91554a958d501bdf78d0d4fc8c8f53713
|
@CoodeRver plz fix the e2e |
|
@CoodeRver: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Change-Id: Iaa4e20c6981074aef6ce6932fc0aa8c4ae4efe8f
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews