Prevent the default variants to be used as fallback#163
Open
Vampire wants to merge 1 commit into
Open
Conversation
Vampire
force-pushed
the
prevent-default-variants
branch
from
240060e to
8b21a89
Compare
Author
|
I've just seen this is also done in the LWJGL example in the Gradle docs: https://docs.gradle.org/current/userguide/component_metadata_rules.html#adding_variants_for_native_jars |
jjohannes
approved these changes
Jan 22, 2024
Contributor
jjohannes
left a comment
jjohannes
left a comment
There was a problem hiding this comment.
I agree that this is a good addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you for example request Windows/x86, as no variant is configured for it, you get the default variants
with the empty jars. With this additional attribute change, you instead get an error that no matching variant is found.
@jjohannes what do you think?