Inject classpath into test + use individual test projects#148
Open
abhinayagarwal wants to merge 2 commits into
Open
Inject classpath into test + use individual test projects#148abhinayagarwal wants to merge 2 commits into
abhinayagarwal wants to merge 2 commits into
Conversation
tiainen
reviewed
May 5, 2023
tiainen
approved these changes
May 5, 2023
jperedadnr
reviewed
May 8, 2023
| assertEquals(TaskOutcome.SUCCESS, result.task(":run").getOutcome(), "Failed build!"); | ||
| } | ||
|
|
||
| private List<File> pluginClasspath() { |
Collaborator
There was a problem hiding this comment.
You are reading it three times, while it could probably be done in one previous setup single step?
|
This PR has conflicts now that #151 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer have to depend on a snapshot build of the plugin to run the tests. Instead the plugin is build and its entire classpath in injected into the test.
Fixes #147