8387252: [lworld] LoadFlattenedArrayStub may not consider the spill inserted by RA#2579
Open
zifeihan wants to merge 1 commit into
Open
8387252: [lworld] LoadFlattenedArrayStub may not consider the spill inserted by RA#2579zifeihan wants to merge 1 commit into
zifeihan wants to merge 1 commit into
Conversation
|
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| // Otherwise, the RA may insert a spill at the load's def point | ||
| // (inside the conditional code), and the stub's continuation jump | ||
| // would skip that spill, leaving the spill slot stale. | ||
| load_result = new_register(T_OBJECT); |
Member
There was a problem hiding this comment.
Shouldn't the rlock_result just above in line 2381 do exactly that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, as discussed here, openjdk/jdk#31122 (comment)
I think there's a bug here. Although this issue occurs on RISC-V, we can see that this spill was automatically inserted by RA; we didn't perform any operations manually.
And maybe the reason of a spill move [c_rarg5|L] [stack:10|L] inserted by RA is probably because the registers are under a lot of pressure at this stage.
I created a new issue to track https://bugs.openjdk.org/browse/JDK-8387252, and I'll try to reproduce this bug on other architectures.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2579/head:pull/2579$ git checkout pull/2579Update a local copy of the PR:
$ git checkout pull/2579$ git pull https://git.openjdk.org/valhalla.git pull/2579/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2579View PR using the GUI difftool:
$ git pr show -t 2579Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2579.diff
Using Webrev
Link to Webrev Comment