Skip to content

8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes#2422

Open
shivshah-oracle wants to merge 6 commits into
openjdk:lworldfrom
shivshah-oracle:JDK-8384109
Open

8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes#2422
shivshah-oracle wants to merge 6 commits into
openjdk:lworldfrom
shivshah-oracle:JDK-8384109

Conversation

@shivshah-oracle

@shivshah-oracle shivshah-oracle commented May 11, 2026

Copy link
Copy Markdown
Contributor

Added value class variants for NegativeArraySizeException tests, migrated types (Integer) and custom value classes (Point) with @enablePreview.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2422/head:pull/2422
$ git checkout pull/2422

Update a local copy of the PR:
$ git checkout pull/2422
$ git pull https://git.openjdk.org/valhalla.git pull/2422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2422

View PR using the GUI difftool:
$ git pr show -t 2422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2422.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 11, 2026

Copy link
Copy Markdown

👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 11, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title 8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes 8384109: [lworld] Update NegativeArraySizeExceptionTest to check arrays of value classes May 11, 2026
@shivshah-oracle shivshah-oracle marked this pull request as ready for review May 11, 2026 23:26
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 11, 2026
@mlbridge

mlbridge Bot commented May 11, 2026

Copy link
Copy Markdown

Webrevs

@lmesnik lmesnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just question, it is possible to reduce code duplication and merge it with existing test sources?


public class NegativeArraySizeExceptionTest {

@AsValueClass
static class Point {
int x;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to have VClass then point
and
have "flattned" value fields (Integer) instead of int

@@ -301,6 +323,19 @@ public static void main(String[] args) throws Exception {
Asserts.assertEQ("-2147483648", e.getMessage());
}


// Tests for value class arrays (migrated Integer and custom Point).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point -> VClass

@bridgekeeper

bridgekeeper Bot commented Jun 18, 2026

Copy link
Copy Markdown

@shivshah-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants