Skip to content

8384108: [lworld] Update runtime/clone tests with value classes#2416

Open
shivshah-oracle wants to merge 4 commits into
openjdk:lworldfrom
shivshah-oracle:JDK-8384108
Open

8384108: [lworld] Update runtime/clone tests with value classes#2416
shivshah-oracle wants to merge 4 commits into
openjdk:lworldfrom
shivshah-oracle:JDK-8384108

Conversation

@shivshah-oracle

@shivshah-oracle shivshah-oracle commented May 8, 2026

Copy link
Copy Markdown
Contributor

Added CloneWithValueFields test to verify clone behavior with value class fields and arrays

Tests cover field cloning, independence, null handling, inheritance, array cloning, and GC survival using migrated value class types (Integer, Long, Double, Short)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8384108: [lworld] Update runtime/clone tests with value classes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2416/head:pull/2416
$ git checkout pull/2416

Update a local copy of the PR:
$ git checkout pull/2416
$ git pull https://git.openjdk.org/valhalla.git pull/2416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2416

View PR using the GUI difftool:
$ git pr show -t 2416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2416.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 8, 2026

Copy link
Copy Markdown

👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 8, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@shivshah-oracle shivshah-oracle changed the title 8384108: Update runtime/clone tests with value classes 8384108: [lworld] Update runtime/clone tests with value classes May 8, 2026
@shivshah-oracle shivshah-oracle marked this pull request as ready for review May 12, 2026 13:46
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 12, 2026
@mlbridge

mlbridge Bot commented May 12, 2026

Copy link
Copy Markdown

Webrevs

@lmesnik lmesnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to combine them with existing tests to reduce code duplication.

@bridgekeeper

bridgekeeper Bot commented Jun 18, 2026

Copy link
Copy Markdown

@shivshah-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants