Skip to content

more#2173

Closed
rwestrel wants to merge 11 commits into
openjdk:lworldfrom
rwestrel:more_ea
Closed

more#2173
rwestrel wants to merge 11 commits into
openjdk:lworldfrom
rwestrel:more_ea

Conversation

@rwestrel

@rwestrel rwestrel commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

XXXX


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Warning

 ⚠️ Patch contains a binary file (test/jdk/java/util/jar/JarEntry/test.jar)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2173/head:pull/2173
$ git checkout pull/2173

Update a local copy of the PR:
$ git checkout pull/2173
$ git pull https://git.openjdk.org/valhalla.git pull/2173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2173

View PR using the GUI difftool:
$ git pr show -t 2173

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2173.diff

@bridgekeeper

bridgekeeper Bot commented Feb 26, 2026

Copy link
Copy Markdown

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Feb 26, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper

bridgekeeper Bot commented Apr 30, 2026

Copy link
Copy Markdown

@rwestrel This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk

openjdk Bot commented Jun 8, 2026

Copy link
Copy Markdown

@rwestrel this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout more_ea
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk Bot added the merge-conflict Pull request has merge conflict with target branch label Jun 8, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

@rwestrel This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper Bot closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict Pull request has merge conflict with target branch

Development

Successfully merging this pull request may close these issues.

1 participant