8384158: GHA: Downgrade Windows GHA runners to windows-2022 temporarily#91
8384158: GHA: Downgrade Windows GHA runners to windows-2022 temporarily#91gnu-andrew wants to merge 1 commit into
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Backport to sync 8u's Windows OS usage with later JDKs, though the use of Cygwin & explicitly VS20{10,17} seems to be avoiding the issues others have seen with Windows 2025. GHA-only change. Keeps the toolchain versions the same as before GitHub changed the version for |
|
@gnu-andrew |
|
/approve yes |
|
@jerboaa |
|
/integrate |
|
Going to push as commit 40657cf. |
|
@gnu-andrew Pushed as commit 40657cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of the change to use Windows 2022 in spirit rather than like-for-like as 8u does not yet have the GHA restructuring provided by JDK-8287906 (something I would like to address in due course)
While 8u isn't being hit by the change to Windows 2025 in the same way (likely because it uses Cygwin and Visual Studio 2010 & 2017), I think it would be good to keep the operating systems consistent across major releases to avoid potential issues unique to the newer environment that other JDKs are not yet using.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/91/head:pull/91$ git checkout pull/91Update a local copy of the PR:
$ git checkout pull/91$ git pull https://git.openjdk.org/jdk8u.git pull/91/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 91View PR using the GUI difftool:
$ git pr show -t 91Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/91.diff
Using Webrev
Link to Webrev Comment