Skip to content

8269029: compiler/codegen/TestCharVect2.java fails for client VMs#837

Open
wkia wants to merge 2 commits into
openjdk:masterfrom
wkia:bp8269029
Open

8269029: compiler/codegen/TestCharVect2.java fails for client VMs#837
wkia wants to merge 2 commits into
openjdk:masterfrom
wkia:bp8269029

Conversation

@wkia

@wkia wkia commented Jun 30, 2026

Copy link
Copy Markdown

This is backport of "8269029 compiler/codegen/TestCharVect2.java fails for client VMs" to jdk8u as Windows 32bit build fails on this test because of the absense of the VM options.

Simple conflict resolution, original change has an additional arg in the context lines. However, I had to change the implementation, as there are no properties vm.compiler2.enabled | vm.graal.enabled in JDK8, so I've replaced them with vm.flavor == "server" as the problem occurs on client VMs.

Test failures in jdk/security_infra are not related to the change.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8269029 needs maintainer approval

Issue

  • JDK-8269029: compiler/codegen/TestCharVect2.java fails for client VMs (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/837/head:pull/837
$ git checkout pull/837

Update a local copy of the PR:
$ git checkout pull/837
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 837

View PR using the GUI difftool:
$ git pr show -t 837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/837.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 30, 2026

Copy link
Copy Markdown

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 30, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport cbec37d45d77533081c27b3fc649098dfcca0425 8269029: compiler/codegen/TestCharVect2.java fails for client VMs Jun 30, 2026
@openjdk

openjdk Bot commented Jun 30, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 30, 2026
@mlbridge

mlbridge Bot commented Jun 30, 2026

Copy link
Copy Markdown

Webrevs

@wkia wkia closed this Jun 30, 2026
@wkia wkia reopened this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant