Skip to content

8384902: Update GIFlib to 6.1.3#827

Open
vieiro wants to merge 1 commit into
openjdk:masterfrom
vieiro:backports/JDK-8384902
Open

8384902: Update GIFlib to 6.1.3#827
vieiro wants to merge 1 commit into
openjdk:masterfrom
vieiro:backports/JDK-8384902

Conversation

@vieiro

@vieiro vieiro commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Backport of JDK-8384902 from JDK-11.

There's a slight difference from JDK-11 in the way SavedImage *correct_saved_images; is declared in dgif_lib.c/DGifDecreaseImageCounter, introduced when backporting JDK-8379256 to JDK8.

Tested on RH8/gcc 8.5.0 with jdk/test/java/awt/SplashScreen tests, passing:

TEST RESULT: Passed. Execution successful
--------------------------------------------------
Test results: passed: 1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8384902 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/827/head:pull/827
$ git checkout pull/827

Update a local copy of the PR:
$ git checkout pull/827
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 827

View PR using the GUI difftool:
$ git pr show -t 827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/827.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 9, 2026

Copy link
Copy Markdown

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 9, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport b56b1acdd12851adbba14c90eb849c254229b6a8 8384902: Update GIFlib to 6.1.3 Jun 9, 2026
@openjdk

openjdk Bot commented Jun 9, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 9, 2026
@mlbridge

mlbridge Bot commented Jun 9, 2026

Copy link
Copy Markdown

Webrevs

@gnu-andrew gnu-andrew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Yes, VS2010 requires variables to be declared at the top of the block, as we found in openjdk/jdk8u#87

@openjdk

openjdk Bot commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew

Copy link
Copy Markdown
Member

Change looks good.

Yes, VS2010 requires variables to be declared at the top of the block, as we found in openjdk/jdk8u#87

Finally filed this upstream: https://sourceforge.net/p/giflib/code/merge-requests/22/

@vieiro

vieiro commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Mmm... this hunk is very unfortunate...

        GifFile->ImageCount--;
        if (GifFile->SavedImages[GifFile->ImageCount].RasterBits != NULL) {
                free(GifFile->SavedImages[GifFile->ImageCount].RasterBits);
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants