8384902: Update GIFlib to 6.1.3#827
Conversation
|
👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
gnu-andrew
left a comment
There was a problem hiding this comment.
Change looks good.
Yes, VS2010 requires variables to be declared at the top of the block, as we found in openjdk/jdk8u#87
|
|
Finally filed this upstream: https://sourceforge.net/p/giflib/code/merge-requests/22/ |
|
Mmm... this hunk is very unfortunate... |
Backport of JDK-8384902 from JDK-11.
There's a slight difference from JDK-11 in the way
SavedImage *correct_saved_images;is declared indgif_lib.c/DGifDecreaseImageCounter, introduced when backporting JDK-8379256 to JDK8.Tested on RH8/gcc 8.5.0 with
jdk/test/java/awt/SplashScreentests, passing:Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/827/head:pull/827$ git checkout pull/827Update a local copy of the PR:
$ git checkout pull/827$ git pull https://git.openjdk.org/jdk8u-dev.git pull/827/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 827View PR using the GUI difftool:
$ git pr show -t 827Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/827.diff
Using Webrev
Link to Webrev Comment