Skip to content

8284694: Avoid evaluating SSLAlgorithmConstraints twice#822

Open
jerboaa wants to merge 1 commit into
openjdk:pr/820from
jerboaa:jdk-8284694-aviod-sslcrypto-algo
Open

8284694: Avoid evaluating SSLAlgorithmConstraints twice#822
jerboaa wants to merge 1 commit into
openjdk:pr/820from
jerboaa:jdk-8284694-aviod-sslcrypto-algo

Conversation

@jerboaa

@jerboaa jerboaa commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Clean backport modulo path changes and dropping of benchmark tests (not in 8u). This is in preparation for JDK-8349583 that is needed for JDK-8340321.

Testing:

  • jdk/test/javax/net/ssl, jdk/test/sun/net/www/protocol/https/ and jdk/test/sun/security/ssl/ with Test results: passed: 267; failed: 2; error: 1. Same failures as for master.

Thoughts?



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8284694 needs maintainer approval

Integration blocker

 ⚠️ Dependency #820 must be integrated first

Issue

  • JDK-8284694: Avoid evaluating SSLAlgorithmConstraints twice (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/822/head:pull/822
$ git checkout pull/822

Update a local copy of the PR:
$ git checkout pull/822
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 822

View PR using the GUI difftool:
$ git pr show -t 822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/822.diff

Using Webrev

Link to Webrev Comment

8284694: Avoid evaluating SSLAlgorithmConstraints twice
@bridgekeeper

bridgekeeper Bot commented Jun 2, 2026

Copy link
Copy Markdown

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/820 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 2, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport eb8789b54ab42e56453c2cefb86056c82a91aeb0 8284694: Avoid evaluating SSLAlgorithmConstraints twice Jun 2, 2026
@openjdk

openjdk Bot commented Jun 2, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 2, 2026
@mlbridge

mlbridge Bot commented Jun 2, 2026

Copy link
Copy Markdown

Webrevs

@bridgekeeper

bridgekeeper Bot commented Jul 1, 2026

Copy link
Copy Markdown

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa

jerboaa commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant