8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

[jerboaa]

Please review this test-only change for 8u in preparation for JDK-8340321 and JDK-8349583 backports for a crypto roadmap update. The patch is not entirely clean. The most significant differences to JDK 11u are:

• Changes to RestrictSignatureScheme.java are omitted since the bug which introduces this test is not yet in 8u (JDK-8226374). This backport isn't strictly needed and since this backport required already quite a few - mostly - test-only backports as deps I've omitted it.
• SSLContextTemplate.java has been done manually because: a) context changes are large enough so that the patch doesn't apply cleanly b) even if it did, 11u has an extra test, NamedGroupsWithCipherSuite.java which uses SSLSocketTemplate.Cert.CA_DSA_1024, and SSLSocketTemplate.Cert.EE_DSA_1024 and are only used in that test. The test has been introduced with 8224650: Add tests to support X25519 and X448 in TLS and then modified in JDK-8243549 both of which aren't in 8u. Therefore, I've not brought those certs into SSLSocketTemplate. They weren't there before anyway.
• SSLEngineBadBufferArrayAccess.java has a different ssl library path in 8u.
• SSLSocketTemplate.java has the same issue as SSLContextTemplate.java with CA_DSA_1024 and EE_DSA_1024 not being present in 8u.
• SocketExceptionForSocketIssues.java has differences to 11u, because of differences in the JDK-8259662 backport. See 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl #808 for details.
• Same for SigAlgosExtTestWithTLS12.java which needed modifications to the test in JDK-8263188 (8263188: JSSE should fail fast if there isn't supported signature algorithm #811) so that the test compiles on 8u.

Otherwise, the usual path changes apply.

Testing

• jdk/test/javax/net/ssl, jdk/test/sun/net/www/protocol/https/ and jdk/test/sun/security/ssl/ tests with the following result: Test results: passed: 267; failed: 2; error: 1 => same failures as for master. Same number of tests passing as in 8263188: JSSE should fail fast if there isn't supported signature algorithm #811.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8284047 needs maintainer approval

Integration blocker

 ⚠️ Dependency #811 must be integrated first

Issue

• JDK-8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/813/head:pull/813
$ git checkout pull/813

Update a local copy of the PR:
$ git checkout pull/813
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 813

View PR using the GUI difftool:
$ git pr show -t 813

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/813.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/811 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (b0ba9c9e)

[jerboaa]

GHA failures are https://bugs.openjdk.org/browse/JDK-8385585 and https://bugs.openjdk.org/browse/JDK-8385584

[bridgekeeper]

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

/touch

Still waiting on reviews.

[openjdk]

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.