Skip to content

8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails#4546

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8202932-V17
Open

8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails#4546
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8202932-V17

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails.

This PR does some code cleanup for NativeInLightShow.java and removes it from the problem list.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/awt/Component/NativeInLightShow/NativeInLightShow.java

Results:

macos-aarch64-specific-test.log
windows-x64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8202932 needs maintainer approval

Issue

  • JDK-8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4546/head:pull/4546
$ git checkout pull/4546

Update a local copy of the PR:
$ git checkout pull/4546
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4546

View PR using the GUI difftool:
$ git pr show -t 4546

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4546.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8 rm-gh-8 marked this pull request as ready for review June 29, 2026 14:41
@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 7cf68b1901cc6f8ab30f8f8496de10f4017bfc58 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@rm-gh-8

rm-gh-8 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails.

This is a test fix.

For parity with Oracle JDK.

@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@rm-gh-8
8202932: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant