Skip to content

8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception#4536

Open
tkiriyama wants to merge 1 commit into
openjdk:masterfrom
tkiriyama:backport_8365623
Open

8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception#4536
tkiriyama wants to merge 1 commit into
openjdk:masterfrom
tkiriyama:backport_8365623

Conversation

@tkiriyama

@tkiriyama tkiriyama commented Jun 23, 2026

Copy link
Copy Markdown
Member

Hi all,

JDK-8365623 is being backported from JDK 26 to JDK 17 to address an issue where six PKCS#11 TLS tests that handled unavailable-algorithm and failed-initialization conditions would print a skipping message and return. This caused jtreg to misleadingly mark them as "Passed" because no explicit failure occurred. In other words, when PKCS#11 functionality was unavailable, the tests exited normally and were counted the same as successful tests, even though they did not actually verify any functionality.

Additionally, this backport is equivalent to the fix applied in JDK 21. This equivalence ensures consistency and demonstrates that the adjustments are robust and have been previously validated in other releases.

Would everyone review this fix, please?

Thank you.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8365623 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4536/head:pull/4536
$ git checkout pull/4536

Update a local copy of the PR:
$ git checkout pull/4536
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4536

View PR using the GUI difftool:
$ git pr show -t 4536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4536.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip… 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception Jun 23, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 23, 2026
@mlbridge

mlbridge Bot commented Jun 23, 2026

Copy link
Copy Markdown

Webrevs

@tkiriyama tkiriyama changed the title 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception backport f7b5db1a5be2d8a56bb88c7df0451709ab68de49 Jun 23, 2026
@openjdk openjdk Bot changed the title backport f7b5db1a5be2d8a56bb88c7df0451709ab68de49 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception Jun 23, 2026
@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant