8382392: Mixed jstack does not work on Alpine#30815
Open
YaSuenag wants to merge 7 commits intoopenjdk:masterfrom
Open
8382392: Mixed jstack does not work on Alpine#30815YaSuenag wants to merge 7 commits intoopenjdk:masterfrom
YaSuenag wants to merge 7 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After JDK-8377946, we can see test failure on ClhsdbPstack.java. But the failure was happened before JDK-8377946 - test is passed, but we can see the exception and the function symbol was not been resolved. (You can see .jtr files in JBS)
DwarfParsershould scan.eh_framefirst. but.debug_frameshould be scanned as fallback if target PC was not found in.eh_frame.According to System V ABI for AMD64, frame information should be included in .eh_frame (See 6.3 Unwinding Through Assembler Code)
In musl C, I found out the discussion for .eh_frame vs .debug_frame: https://www.openwall.com/lists/musl/2021/07/17/13
musl C does not seem to want to support
.eh_frame- they seem to want to use.debug_framefor stack unwinding in debugging. But it could be different from ABI spec in above.This PR is not small, but commit history might help to review.
eh_frame_info..debug_frame, debuginfo related code is needed for this PR, but it is written in symtab.c. So moved it to another file (salibelf.c)..eh_frame, so renamed..debug_frame.current
LinuxAMD64CFramemight enter infinity loop not to find out bottom frame (I saw this case on Alpine), thus add condition for frame validation with stack pointer.Note that all of mixed jstack tests have been disabled on Alpine (musl C) since JDK-8382327. They are re-enabled in this PR.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30815/head:pull/30815$ git checkout pull/30815Update a local copy of the PR:
$ git checkout pull/30815$ git pull https://git.openjdk.org/jdk.git pull/30815/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30815View PR using the GUI difftool:
$ git pr show -t 30815Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30815.diff
Using Webrev
Link to Webrev Comment