8307537: Print blobs/nmethods/adapters stats per code heap in CodeCache::print_summary

[eastig]

This PR adds blobs/nmethods/adapters stats per code heap in CodeCahe::print_summary:

CodeHeap 'non-profiled nmethods': size=118592Kb used=370Kb max_used=370Kb free=118221Kb
 bounds [0x00007f2093d3a000, 0x00007f2093faa000, 0x00007f209b10a000]
 blobs=397, nmethods=397, adapters=0, full_count=0
CodeHeap 'profiled nmethods': size=118592Kb used=2134Kb max_used=2134Kb free=116457Kb
 bounds [0x00007f208c109000, 0x00007f208c379000, 0x00007f20934d9000]
 blobs=1091, nmethods=1091, adapters=0, full_count=0
CodeHeap 'non-nmethods': size=8580Kb used=4461Kb max_used=4506Kb free=4118Kb
 bounds [0x00007f20934d9000, 0x00007f2093949000, 0x00007f2093d3a000]
 blobs=478, nmethods=0, adapters=387, full_count=0
CodeCache: size=245764Kb, used=6965Kb, max_used=7010Kb, free=238796Kb
 total_blobs=1966, nmethods=1488, adapters=387, full_count=0
Compilation: enabled, stopped_count=0, restarted_count=0

This information is useful for debugging CodeCache.

Testing: fastdebug, tier1-tier2 passed.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8307537: Print blobs/nmethods/adapters stats per code heap in CodeCache::print_summary (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Damon Fenacci (@dafedafe - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30803/head:pull/30803
$ git checkout pull/30803

Update a local copy of the PR:
$ git checkout pull/30803
$ git pull https://git.openjdk.org/jdk.git pull/30803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30803

View PR using the GUI difftool:
$ git pr show -t 30803

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30803.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307537: Print blobs/nmethods/adapters stats per code heap in CodeCache::print_summary

Reviewed-by: kvn, dfenacci

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• b854ba1: 8382441: Problemlist TestStressAllocationGCEventsWithShenandoah and TestStressBigAllocationGCEventsWithShenandoah
• d8e3813: 8382054: TestLoopPeelingDisabled.java fails with -DVerifyIR=false
• 9a3588b: 8379744: Add a way to update the key of a red-black tree node
• ... and 29 more: https://git.openjdk.org/jdk/compare/877425a15825ae4e1eafa4c90807e05679e48474...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@eastig The following labels will be automatically applied to this pull request:

• hotspot-compiler
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ed11fa1f)
• 00: Full (65b00abf)

[vnkozlov]

Good. One comment.

[vnkozlov]

Should we use ' ': total blobs since total relates to all counts in this line,

[eastig]

Agree it is better to use ' '.

[eastig]

Done

[vnkozlov]

Unfortunately get_codemem_full_count() is also used by JFR. Otherwise we could remove it.

[vnkozlov]

Good. I submitted our testing.

[dafedafe]

Nice and useful addition to the CodeCache summary. Thanks @eastig for exposing the counts. LGTM

[vnkozlov]

My testing passed. Good.

[eastig]

@vnkozlov @dafedafe Thank you for reviewing.

[eastig]

/integrate

[openjdk]

Going to push as commit 8353f2e.
Since your change was applied there have been 49 commits pushed to the master branch:

• 5586f40: 8382499: G1: Let non young cset choice time also use Ticks API for measurements
• 96f2cba: 8381642: javac provides the wrong line number for an error in a lambda expression
• a37fd2b: 8367330: Loosen container detection to include soft limits
• ... and 46 more: https://git.openjdk.org/jdk/compare/877425a15825ae4e1eafa4c90807e05679e48474...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eastig Pushed as commit 8353f2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.