Skip to content

8382275: Update nsk/stress/jni to use ThreadWrapper#30795

Open
shivshah-oracle wants to merge 1 commit intoopenjdk:masterfrom
shivshah-oracle:JDK-8382275-thread-wrapper
Open

8382275: Update nsk/stress/jni to use ThreadWrapper#30795
shivshah-oracle wants to merge 1 commit intoopenjdk:masterfrom
shivshah-oracle:JDK-8382275-thread-wrapper

Conversation

@shivshah-oracle
Copy link
Copy Markdown
Contributor

@shivshah-oracle shivshah-oracle commented Apr 17, 2026

Changed jnistress001-007, JNIter classes, and GarbageGenerator to extend ThreadWrapper instead of Thread. Interrupter left as platform thread since it only interrupts other threads and doesn't do test work.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382275: Update nsk/stress/jni to use ThreadWrapper (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30795/head:pull/30795
$ git checkout pull/30795

Update a local copy of the PR:
$ git checkout pull/30795
$ git pull https://git.openjdk.org/jdk.git pull/30795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30795

View PR using the GUI difftool:
$ git pr show -t 30795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30795.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@shivshah-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382275: Update  nsk/stress/jni to use ThreadWrapper

Reviewed-by: lmesnik, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @sendaoYan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title 8382275: Update nsk/stress/jni to use ThreadWrapper 8382275: Update nsk/stress/jni to use ThreadWrapper Apr 17, 2026
@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@shivshah-oracle The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 17, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 17, 2026

Webrevs

@sendaoYan
Copy link
Copy Markdown
Member

Hi, how do we verify the correctness of this change. Run the touched tests by virtual thread and default thread is sufficient or not

@shivshah-oracle
Copy link
Copy Markdown
Contributor Author

Hi, how do we verify the correctness of this change. Run the touched tests by virtual thread and default thread is sufficient or not

Ran all 7 on mach5 with and without TEST_THREAD_FACTORY=Virtual, all platforms pass. Running with TEST_THREAD_FACTORY=Virtual proves the tests actually run on virtual threads now which is the whole point of the change and running without proves we didn’t break existing behavior. That’s the verification.. both thread types work.

Copy link
Copy Markdown
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is enough to verify that tests passed in the default mode and with virtual threads.
The threads are transparent and testing in the most cases should just work.

Copy link
Copy Markdown
Member

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants