8382275: Update nsk/stress/jni to use ThreadWrapper#30795
8382275: Update nsk/stress/jni to use ThreadWrapper#30795shivshah-oracle wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into |
|
@shivshah-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @sendaoYan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@shivshah-oracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
Hi, how do we verify the correctness of this change. Run the touched tests by virtual thread and default thread is sufficient or not |
Ran all 7 on mach5 with and without TEST_THREAD_FACTORY=Virtual, all platforms pass. Running with TEST_THREAD_FACTORY=Virtual proves the tests actually run on virtual threads now which is the whole point of the change and running without proves we didn’t break existing behavior. That’s the verification.. both thread types work. |
lmesnik
left a comment
There was a problem hiding this comment.
I think it is enough to verify that tests passed in the default mode and with virtual threads.
The threads are transparent and testing in the most cases should just work.
Changed jnistress001-007, JNIter classes, and GarbageGenerator to extend ThreadWrapper instead of Thread. Interrupter left as platform thread since it only interrupts other threads and doesn't do test work.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30795/head:pull/30795$ git checkout pull/30795Update a local copy of the PR:
$ git checkout pull/30795$ git pull https://git.openjdk.org/jdk.git pull/30795/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30795View PR using the GUI difftool:
$ git pr show -t 30795Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30795.diff
Using Webrev
Link to Webrev Comment