Skip to content

8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist#30793

Closed
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:problemlist/8382420_toBack_macos
Closed

8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist#30793
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:problemlist/8382420_toBack_macos

Conversation

@azvegint
Copy link
Copy Markdown
Member

@azvegint azvegint commented Apr 17, 2026

Removing no longer failing tests from the problemlist



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30793/head:pull/30793
$ git checkout pull/30793

Update a local copy of the PR:
$ git checkout pull/30793
$ git pull https://git.openjdk.org/jdk.git pull/30793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30793

View PR using the GUI difftool:
$ git pr show -t 30793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30793.diff

Using Webrev

Link to Webrev Comment

@azvegint
Copy link
Copy Markdown
Member Author

/label client

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist

Reviewed-by: dmarkov, aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@azvegint azvegint changed the title 8382420: [macos] remove java/awt/Modal/ToBack/ from problemlist 8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist Apr 17, 2026
@openjdk openjdk Bot added the client client-libs-dev@openjdk.org label Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@azvegint
The client label was successfully added.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@azvegint To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 17, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 17, 2026

Webrevs

@aivanov-jdk
Copy link
Copy Markdown
Member

Did anything change so that these tests have stopped failing?

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 17, 2026
@prrace
Copy link
Copy Markdown
Contributor

prrace commented Apr 17, 2026

Did anything change so that these tests have stopped failing?

They were part of a big problem-listing > 8 years ago

Bug: https://bugs.openjdk.java.net/browse/JDK-8198693
webrev: http://cr.openjdk.java.net/~psadhukhan/8198693/webrev.00/

Sounds like intermittent failures and no logs were provided showing how they failed.
So many things changed in that time ...

@azvegint
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

Going to push as commit 5b8ac19.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 20, 2026
@openjdk openjdk Bot closed this Apr 20, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

@azvegint Pushed as commit 5b8ac19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk
Copy link
Copy Markdown
Member

Did anything change so that these tests have stopped failing?

They were part of a big problem-listing > 8 years ago

Got it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants