8382423: G1: Remove unused G1GCPhaseTimes::_external_accounted_time_ms

[tschatzl]

Hi all,

please review this removal of the dead G1GCPhaseTimes::_external_accounted_time_ms and associated methods.

Testing: local compilation, gha

Thanks,
Thomas

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8382423: G1: Remove unused G1GCPhaseTimes::_external_accounted_time_ms (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30792/head:pull/30792
$ git checkout pull/30792

Update a local copy of the PR:
$ git checkout pull/30792
$ git pull https://git.openjdk.org/jdk.git pull/30792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30792

View PR using the GUI difftool:
$ git pr show -t 30792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30792.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382423: G1: Remove unused G1GCPhaseTimes::_external_accounted_time_ms

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (4a909af8)

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 62bd83a.
Since your change was applied there have been 22 commits pushed to the master branch:

• 48b6da7: 8382422: G1: G1GCPhaseTimes::record_merge_heap_roots() uses += instead of direct assignment
• 5b8ac19: 8382420: [macos] remove java/awt/Modal/ToBack/ tests from problemlist
• f1eac21: 8378462: Build fails with --enable-linktime-gc set when using some devkits/toolchains
• ... and 19 more: https://git.openjdk.org/jdk/compare/877425a15825ae4e1eafa4c90807e05679e48474...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 62bd83a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.