8382419: Add missed @key randomness after JDK-8370489

[GoeLin]

Tiny issue I ran into backporting JDK-8370489.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8382419: Add missed @key randomness after JDK-8370489 (Enhancement - P5)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) Review applies to 6fc80997
• Christian Hagedorn (@chhagedorn - Reviewer) Review applies to 6fc80997
• SendaoYan (@sendaoYan - Committer)
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30790/head:pull/30790
$ git checkout pull/30790

Update a local copy of the PR:
$ git checkout pull/30790
$ git pull https://git.openjdk.org/jdk.git pull/30790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30790

View PR using the GUI difftool:
$ git pr show -t 30790

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30790.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382419: Add missed @key randomness after JDK-8370489

Reviewed-by: syan, epeter, shade, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• abd3d46: 8382401: Remove return type parameters from FREE_ and REALLOC_ macros
• 9a689b0: 8382393: Enable VectorStoreMaskIdentityTest.java IR tests for RISC-V
• eac3968: 8381012: Add warning for == for MemorySegment.NULL
• ... and 25 more: https://git.openjdk.org/jdk/compare/877425a15825ae4e1eafa4c90807e05679e48474...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@GoeLin The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2e566d9a)
• 00: Full (6fc80997)

[chhagedorn]

Looks good and trivial.

[sendaoYan]

LGTM

[sendaoYan]

Should we update the copyright year.

[GoeLin]

Sure, good point. Fixed.

[GoeLin]

/reviewers 1

[openjdk]

@GoeLin
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

[eme64]

LGTM, thanks for adding it!

[GoeLin]

Thanks for all the reviews! Probably the best complexity/review relation ever :P.
Maybe skara should recognize Copyright updates and not require a re-review in that case?

[GoeLin]

/integrate

[openjdk]

Going to push as commit e7ee8cd.
Since your change was applied there have been 43 commits pushed to the master branch:

• 1f782b7: 8382395: Disable stringop-overflow in shenandoahGenerationalHeap.cpp
• 3d72318: 8382359: Align 32-bit data in AOT Code Cache to sizeof(uint)
• 35a499e: 8335355: Shenandoah: Fix race condition in gc/shenandoah/mxbeans/TestPauseNotifications.java
• ... and 40 more: https://git.openjdk.org/jdk/compare/877425a15825ae4e1eafa4c90807e05679e48474...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit e7ee8cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.