8382335: gc/stress/jfr/TestStressAllocationGCEventsWithShenandoah.java intermittently fails with OOME#30787
8382335: gc/stress/jfr/TestStressAllocationGCEventsWithShenandoah.java intermittently fails with OOME#30787rgithubli wants to merge 1 commit intoopenjdk:masterfrom
Conversation
…a intermittently fails with OOME
|
👋 Welcome back ruili! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@rgithubli The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
| import java.util.concurrent.Semaphore; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.locks.LockSupport; |
There was a problem hiding this comment.
Should we update the copyright year.
| import java.util.concurrent.Semaphore; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.locks.LockSupport; |
There was a problem hiding this comment.
I can not find the use of LockSupport. Seems do not need for now.
|
After apply the proposed patch, there are other failure report, shows below: java.lang.RuntimeException: No events: expected false, was true |
|
Thanks for testing out this patch @sendaoYan . Problemlisted these two tests before coming up a better solution: #30802 |
JDK-8382335.
The root cause likely to be the too fast allocation, especially with the
Bigtest, which only allocates humongous objects. It does need to create some heap pressure to haveAllocationRequiringGCevents, but the test creates a bit too much for shenandoah.Tuned down the allocation in this change.
test/hotspot/jtreg/gc/stress/jfrpassed locally. Running 100 repetition locally now.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30787/head:pull/30787$ git checkout pull/30787Update a local copy of the PR:
$ git checkout pull/30787$ git pull https://git.openjdk.org/jdk.git pull/30787/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30787View PR using the GUI difftool:
$ git pr show -t 30787Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30787.diff