Skip to content

8382335: gc/stress/jfr/TestStressAllocationGCEventsWithShenandoah.java intermittently fails with OOME#30787

Draft
rgithubli wants to merge 1 commit intoopenjdk:masterfrom
rgithubli:8382335
Draft

8382335: gc/stress/jfr/TestStressAllocationGCEventsWithShenandoah.java intermittently fails with OOME#30787
rgithubli wants to merge 1 commit intoopenjdk:masterfrom
rgithubli:8382335

Conversation

@rgithubli
Copy link
Copy Markdown
Contributor

@rgithubli rgithubli commented Apr 17, 2026

JDK-8382335.

The root cause likely to be the too fast allocation, especially with the Big test, which only allocates humongous objects. It does need to create some heap pressure to have AllocationRequiringGC events, but the test creates a bit too much for shenandoah.

Tuned down the allocation in this change. test/hotspot/jtreg/gc/stress/jfr passed locally. Running 100 repetition locally now.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382335: gc/stress/jfr/TestStressAllocationGCEventsWithShenandoah.java intermittently fails with OOME (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30787/head:pull/30787
$ git checkout pull/30787

Update a local copy of the PR:
$ git checkout pull/30787
$ git pull https://git.openjdk.org/jdk.git pull/30787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30787

View PR using the GUI difftool:
$ git pr show -t 30787

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30787.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back ruili! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@rgithubli The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

import java.util.concurrent.Semaphore;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.LockSupport;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the copyright year.

import java.util.concurrent.Semaphore;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.LockSupport;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find the use of LockSupport. Seems do not need for now.

@sendaoYan
Copy link
Copy Markdown
Member

After apply the proposed patch, there are other failure report, shows below:

java.lang.RuntimeException: No events: expected false, was true
at jdk.test.lib.Asserts.fail(Asserts.java:715)
at jdk.test.lib.Asserts.assertFalse(Asserts.java:520)
at jdk.test.lib.jfr.Events.hasEvents(Events.java:160)
at jdk.jfr.event.gc.detailed.StressAllocationGCEvents.run(StressAllocationGCEvents.java:92)
at jdk.jfr.event.gc.detailed.TestStressAllocationGCEventsWithShenandoah.main(TestStressAllocationGCEventsWithShenandoah.java:47)

@rgithubli
Copy link
Copy Markdown
Contributor Author

Thanks for testing out this patch @sendaoYan . Problemlisted these two tests before coming up a better solution: #30802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants