Make the examples make better sense#328
Merged
Merged
Conversation
peppelinux
approved these changes
Jan 17, 2026
selfissued
temporarily deployed
to
github-pages
GitHub Actions
Inactive
rohe
approved these changes
Jan 19, 2026
sakimura
approved these changes
Jan 19, 2026
selfissued
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #327 - Use separate examples for Intermediate and OP Entity Configurations. This involved changing the overloaded entity name openid.sunet.se to use three separate names: sunet.se for the Intermediate, rp.sunet.se for the RP, and op.sunet.se for the OP.
Changed some "iss" and "exp" dates in examples so they make better sense.
Changed "kid" values in examples to be plausible JWK Thumbprint values for their keys.
Fixed an inconsistency where part of an example used https://op.umu.se/openid as the issuer and part of it used https://op.umu.se. It now consistently uses https://op.umu.se as the issuer.
Fixed an inconsistency in an example where umu.se URLs were used for sunet.se metadata.
Also fixed some inconsistencies with trailing slashes in issuer names.
Cc: @surfnet-niels