Fix/4745 fix sam targeting nuke pathing

[JB940]

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #4745 bullet points 1, 2, 4, 6 and 8. A new issue will be made for the other bullet points, as they are lower priority.

Description:

Describe the PR.

Please complete the following:

• [x ] I have added screenshots for all UI updates
• [x ] I process any text displayed to the user through translateText() and I've added it to the en.json file
• [x ] I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

JB940

[coderabbitai]

Walkthrough

SAM targeting now ranks and launches multiple interception candidates, while the statistics UI gains typed player/team columns, clan-tag propagation, dynamic layouts, and an in-table sticky ranking row. Curve spacing retains accumulated distance between cached points.

Changes

SAM targeting and interception

Layer / File(s)	Summary
Target discovery and ordering src/core/execution/SAMLauncherExecution.ts	Candidates are detected across an expanded range, scored, cached, collected, and returned in sorted order.
Multi-target launch execution and tests src/core/execution/SAMLauncherExecution.ts, tests/core/executions/SAMLauncherExecution.test.ts	SAM launches ordered targets until cooldown; tests cover dangerous targets, multiple AtomBombs, and MIRV warheads.

Statistics and leaderboard UI

Layer / File(s)	Summary
Clan data propagation src/core/game/*, src/client/view/*, src/client/render/types/Renderer.ts	Nullable clan tags are included in player updates, diffs, snapshots, and privacy-aware player views.
Statistics column contracts src/client/StatsConstants.ts, src/client/hud/layers/lib/StatsColumns.ts	Column definitions now provide typed cells, layout metadata, table-kind filtering, identity columns, and value-backed ordering.
Dynamic statistics table src/client/components/StatsTable.ts, src/client/hud/layers/PlayerStats.ts, src/client/hud/layers/TeamStats.ts	Player and team tables render different column sets with dynamic sizing, sorting, virtualization, picker controls, and clan cells.
Leaderboard row layout and validation src/client/components/leaderboard/LeaderboardPlayerList.ts, tests/*	The sticky ranking row is rendered as a table footer, ranked rows omit API clan tags, and tests cover column behavior, defaults, and rendering.

Bezier curve spacing

Layer / File(s)	Summary
Preserve curve spacing remainder src/core/utilities/Line.ts, tests/core/pathfinding/UniversalPathFinding.Parabola.test.ts	Curve point generation retains excess spacing distance, and path-length expectations are updated.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PlayerImpl
  participant GameUpdateUtils
  participant PlayerView
  participant StatsTable
  participant LeaderboardPlayerList
  PlayerImpl->>GameUpdateUtils: emit clanTag in player update
  GameUpdateUtils-->>PlayerView: apply clanTag delta
  PlayerView-->>StatsTable: provide clanTag row data
  StatsTable->>LeaderboardPlayerList: render columns and rows
  LeaderboardPlayerList-->>StatsTable: render sticky ranking footer

Loading

Possibly related PRs

• openfrontio/OpenFrontIO#4706: Changes the SAM interception pipeline and target handling.
• openfrontio/OpenFrontIO#4744: Overlaps with the clan-tag and statistics-column refactor.
• openfrontio/OpenFrontIO#4713: Overlaps with ranked leaderboard clan-tag removal and sticky-row rendering.

Suggested labels: Backend, UI/UX

Poem

SAMs scan the skies anew,
Clan tags travel safely through.
Columns sort and rows align,
Sticky ranks stay in line.
Curves keep spacing smooth and bright.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The leaderboard, stats, clan-tag, and credits changes are unrelated to SAM pathing and go beyond issue #4745.	Move the UI, localization, clan-tag, and credits work into a separate PR, and keep this one focused on SAM and nuke pathing fixes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 23.08% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately describes the main SAM targeting and nuke pathing fix.
Description check	✅ Passed	The description is related to the PR and references the same issue and SAM pathing work, despite being mostly template text.
Linked Issues check	✅ Passed	The changes implement the addressed #4745 bullets: pathing sampling, wider detection, target prioritization, and multiple SAM shots per tick.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[JB940]

Ofcourse I forgot prettier, one second.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/core/execution/SAMLauncherExecution.ts (1)

80-97: 🎯 Functional Correctness | 🔵 Trivial

Duplicate "ticks remaining until explosion" computation.

computeInterceptionTile's explosionTick and computeTargetScore's timeToExplode both derive trajectory.length - currentIndex from unit.trajectory()/unit.trajectoryIndex(), just with a different floor (Math.max(1, ...) vs none). Extracting a small shared helper would remove the duplication and keep the two calculations in sync if the formula ever changes.

♻️ Proposed helper

+  private remainingTicksToExplode(unit: Unit): number {
+    return unit.trajectory().length - unit.trajectoryIndex();
+  }
+
   private computeInterceptionTile(
     unit: Unit,
     samTile: TileRef,
     rangeSquared: number,
   ): InterceptionTile | undefined {
     const trajectory = unit.trajectory();
     const currentIndex = unit.trajectoryIndex();
-    const explosionTick: number = trajectory.length - currentIndex;
+    const explosionTick: number = this.remainingTicksToExplode(unit);

Also applies to: 99-126

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/execution/SAMLauncherExecution.ts` around lines 80 - 97, Extract the
shared “ticks remaining until explosion” calculation into a helper near
computeInterceptionTile and computeTargetScore, using the existing trajectory
and trajectoryIndex values and preserving the required floor behavior for each
caller. Replace explosionTick and timeToExplode derivations with this helper so
both methods stay synchronized.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/utilities/Line.ts`:
- Around line 147-150: Add regression coverage for the spacing logic in Line.ts
under tests/**/*.test.ts, using setup(). Verify that excess cumulative distance
is retained after a point is emitted and that long-distance curves continue
producing correctly spaced points across multiple intervals.

---

Nitpick comments:
In `@src/core/execution/SAMLauncherExecution.ts`:
- Around line 80-97: Extract the shared “ticks remaining until explosion”
calculation into a helper near computeInterceptionTile and computeTargetScore,
using the existing trajectory and trajectoryIndex values and preserving the
required floor behavior for each caller. Replace explosionTick and timeToExplode
derivations with this helper so both methods stay synchronized.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e7f92dd1-8a95-446f-902e-4383e216b1d0

📥 Commits

Reviewing files that changed from the base of the PR and between 73b086a and 470db04.

📒 Files selected for processing (3)

• src/core/execution/SAMLauncherExecution.ts
• src/core/utilities/Line.ts
• tests/core/executions/SAMLauncherExecution.test.ts

[coderabbitai]

🧹 Nitpick comments (1)

src/client/view/PlayerView.ts (1)

441-445: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

Own clan tag also disappears under anonymous names.

name()/displayName() keep working for the local player because their anonymousName is their real name, so the returned string is unchanged. clanTag() has no such escape: with anonymous names on, your own row loses the tag while your name stays intact. If that asymmetry is not wanted, gate on "not me" instead.

♻️ Optional: keep the local player's own tag

   clanTag(): string | null {
-    return this.anonymousName !== null && userSettings.anonymousNames()
+    return !this.isMe() && userSettings.anonymousNames()
       ? null
       : this.static.clanTag;
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/client/view/PlayerView.ts` around lines 441 - 445, Update
PlayerView.clanTag() so anonymous-name masking applies only to other players,
not the local player; gate the null return on the existing local-player identity
check while preserving the current userSettings.anonymousNames() behavior for
non-local players.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/client/view/PlayerView.ts`:
- Around line 441-445: Update PlayerView.clanTag() so anonymous-name masking
applies only to other players, not the local player; gate the null return on the
existing local-player identity check while preserving the current
userSettings.anonymousNames() behavior for non-local players.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba5fc5fe-fba3-4332-80a9-4a5cd1f45e61

📥 Commits

Reviewing files that changed from the base of the PR and between 8629b22 and 3ded1bf.

⛔ Files ignored due to path filters (1)

• resources/images/GuildIconWhite.svg is excluded by !**/*.svg

📒 Files selected for processing (30)

• CREDITS.md
• resources/lang/en.json
• src/client/StatsConstants.ts
• src/client/components/StatsTable.ts
• src/client/components/leaderboard/LeaderboardPlayerList.ts
• src/client/hud/HotbarIcons.ts
• src/client/hud/layers/PlayerStats.ts
• src/client/hud/layers/TeamStats.ts
• src/client/hud/layers/lib/StatsColumns.ts
• src/client/render/types/Renderer.ts
• src/client/view/GameView.ts
• src/client/view/PlayerView.ts
• src/core/ApiSchemas.ts
• src/core/game/Game.ts
• src/core/game/GameUpdateUtils.ts
• src/core/game/GameUpdates.ts
• src/core/game/PlayerImpl.ts
• src/core/game/UserSettings.ts
• tests/ColumnPicker.test.ts
• tests/GameLeftSidebar.test.ts
• tests/GameUpdateUtils.test.ts
• tests/PlayerStats.test.ts
• tests/PlayerUpdateDiff.test.ts
• tests/StatsColumns.test.ts
• tests/StatsTableVirtualization.test.ts
• tests/TeamStats.test.ts
• tests/UserSettings.test.ts
• tests/client/LeaderboardModal.test.ts
• tests/client/view/PlayerView.test.ts
• tests/util/viewStubs.ts