fix: ensure to_file() output ends with trailing newline#2205
Open
gaoflow wants to merge 1 commit into
Open
Conversation
POSIX-conformant text files should end with a newline character. For example, concatenating two OFFXML files with cat squishes the closing tag of the first with the opening tag of the second. Add a trailing newline to the XML output written by to_file(). Fixes: openforcefield#1761 Signed-off-by: Vincent Gao <gaobing1230@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX-conformant text files should end with a newline character.
Without it, concatenating two OFFXML files with
catsquishes theclosing tag of the first file with the opening tag of the second.
Add a trailing newline to the XML output written by
to_file().Fixes: #1761