Replace shorthand status flag with long verion in get.sh#440
Merged
alexellis merged 1 commit intoopenfaas:masterfrom Jul 16, 2018
Merged
Replace shorthand status flag with long verion in get.sh#440alexellis merged 1 commit intoopenfaas:masterfrom
alexellis merged 1 commit intoopenfaas:masterfrom
Conversation
As part of the graceful degradation change use of sha256sum was introduced. On Ubuntu 16.04 the shorthand flag for status does not exist which results in a failure when verifying the checksum. Further, support for -s & the long --status is inconsistent across distros. This change replaces the -s option which suppresses output in favour of redirection to /dev/null. Signed-off-by: Richard Gee <richard@technologee.co.uk>
Member
|
Since this has been tested and seems urgent (we have a workshop on today at OSCON) I'll merge right away. |
Member
|
Member
|
MacOS Should we at some point hint that we verified the SHA - for the times we did? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Gee richard@technologee.co.uk
Description
This change replaces the -s option for shasum, which suppresses output, in favour of redirection to /dev/null.
Motivation and Context
As part of the graceful degradation change use of sha256sum was introduced.
On Ubuntu 16.04 the shorthand flag for status does not exist which results in
a failure when verifying the checksum. Further, support for -s & the long --status flag
is inconsistent across distros.
How Has This Been Tested?
Pre-tested on Ubuntu 16.04 to validate reported issue
Post-tested on Ubuntu 16.04, MacOS and PWD to get a broad coverage of scenarios.
Types of changes
Checklist:
git commit -s