Version 1.20260720.0 - #583
Merged
Merged
Conversation
Indeed, Xcode's Clang uses host-specific CPU tuning while Homebrew's Clang doesn't. LLVM+Clang is built on GitHub Actions using Xcode's Clang which means that when we want to use the static version of libOpenCOR using Homebrew's Clang then we will get told about `zcm`/`zcz` not being recognised. Normally, we wouldn't want to use `-mcpu=generic` since it would affect runtime performance, but it's negligible for libOpenCOR's use case, so the current "fix" is fine.
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version and updates third-party build/retrieval configuration to align with a new LLVM/Clang prebuilt set and updated WebAssembly platform naming.
Changes:
- Bump
VERSION.txtto1.20260720.0. - Update
src/3rdparty/LLVMClang/CMakeLists.txtprebuilt package SHA1s and adjust build args (Emscripten tablegen args, enabling libc++ for Emscripten, and Apple arm-mcpu=genericcache flags). - Rename the Emscripten
TARGET_PLATFORM_ARCHITECTUREfromwasm-threadedtowasmincmake/packages.cmake, affecting prebuilt package naming/paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VERSION.txt | Updates the library version for the new release. |
| src/3rdparty/LLVMClang/CMakeLists.txt | Refreshes prebuilt hashes and tweaks LLVM/Clang build configuration for Emscripten and Apple arm. |
| cmake/packages.cmake | Changes the Emscripten target platform architecture name used in prebuilt package filenames/paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.