Skip to content

GHA: ninja has been fixed, so can once again use its latest version #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agarny merged 4 commits into from
Aug 18, 2025
Merged

GHA: ninja has been fixed, so can once again use its latest version #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9416ce9
Ensure that `.gitignore` doesn't get deleted on Windows when calling …
agarny Aug 18, 2025
3111194
GHA: ninja has been fixed, so can once again use its latest version.
agarny Aug 17, 2025
c9a9932
pyproject.toml: don't specify version requirements for scikit-build.
agarny Aug 17, 2025
b44ac07
pyproject.toml: removed the need for `ninja`.
agarny Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/buildThirdPartyLibrary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ jobs:
uses: actions/checkout@v4
- name: Install CMake and Ninja
uses: lukka/get-cmake@latest
with:
ninjaVersion: 1.12.1
# Note: use version 1.12.1 since version 1.13+ results in an error message on Ubuntu 22.04 LTS ARM:
# ninja: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by ninja)
- name: Install buildcache
uses: opencor/buildcache-action@v1
with:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ jobs:
uses: actions/checkout@v4
- name: Install CMake and Ninja
uses: lukka/get-cmake@latest
with:
ninjaVersion: 1.12.1
# Note: use version 1.12.1 since version 1.13+ results in an error message on Ubuntu 22.04 LTS ARM:
# ninja: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by ninja)
- name: Install buildcache
uses: opencor/buildcache-action@v1
with:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,6 @@ jobs:
python-version: '3.11'
- name: Install CMake and Ninja
uses: lukka/get-cmake@latest
with:
ninjaVersion: 1.12.1
# Note: use version 1.12.1 since version 1.13+ results in an error message on Ubuntu 22.04 LTS ARM:
# ninja: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by ninja)
- name: Install buildcache
uses: opencor/buildcache-action@v1
with:
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
requires = [
'setuptools',
'wheel',
'scikit-build>=0.12',
'scikit-build',
'cmake',
'ninja',
]
build-backend = 'setuptools.build_meta'

Expand Down
2 changes: 1 addition & 1 deletion scripts/genericclean.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ IF "%1" == "all" (
CD !AppDir!prebuilt

FOR /D %%I IN (*.*) DO RMDIR /S /Q %%I
FOR %%I IN (*.*) DO IF NOT %%I == ".gitignore" DEL /Q %%I
FOR %%I IN (*.*) DO IF NOT "%%I" == ".gitignore" DEL /Q "%%I"
)
)

Expand Down
Loading