Repository navigation
[org] RFC: ways to move PRs forward #3052
Description
Currently all the cooperation between maintainers is almost exclusively limited to whatever means github offers. It seems to be working, except some PRs are stalling for months, causing fixes and features to not be merged, as well as, I guess, some contributor frustration, which may result in losing interest to the project.
I propose to
- Set up a weekly call, or a chat, for all available maintainers to go through existing PRs (and, if needed, issues). We can pre-select a few PRs to review, and go over them in half an hour or so, weekly. I can take a burden to pre-select PRs (and/or we can use Projects kanban board for that, similar to what happens in Moby).
The alternatives are:
-
Have an IRC / Slack / Matrix / whatever channel where maintainers can poke each other (if such channel exists and is specific to runc, I am not aware of it).
-
Lower the bar for PR acceptance/merge to a single LGTM from a maintainer (perhaps even allowing the PR author themselves to LGTM their own work).
Please share your opinions @opencontainers/runc-maintainers
Activity
kolyshkin commentedon Jun 30, 2021
Here's my personal take on this.
I don't like it much as it interrupts my workflow, but I see that this may be the fastest way to accelerate PR review, so I am ready to take part.
This may even work better than a fixed time call/chat because of different timezones we're all in!
While I recognize this as an option to solve the issues stated, I don't like it much as this may result in lower code quality (even now with two or more LGTMs we miss something at times). IOW, I am strongly opposed to it and can only agree if other options were tried and failed.
AkihiroSuda commentedon Jun 30, 2021
Slack (or Matrix) seems better than weekly calling for timezone diversity
dqminh commentedon Jul 28, 2021
Slack or Matrix channel SGTM. I think we have #open-containers in CNCF slack, but that's not specific to runc.
kolyshkin commentedon Aug 31, 2021
OK, we have a private channel
#runcon opencontainers.slack.com, everyone but @crosbymichael seems to be in there. Me and @cyphar tried to mirror that channel to Matrix, with no success (if I remember right, you have to host your own instance of https://github.com/matrix-org/matrix-appservice-slack, as the public one provided by EMS do not allow private channels). Any help is appreciated.@crosbymichael (and everyone else @opencontainers/runc-maintainers) please let us know if you're OK with using this channel, or, if not, please propose an alternative (Matrix, Telegram, Google Chat, a different Slack instance, etc).
kolyshkin commentedon Oct 9, 2026
We have since set up a private
#runcchannel on opencontainers.slack.com for maintainers. Also, the third option (relaxing the merge rules) is now proposed in #5512. Closing.