Add "sequence-id" attribute for each term in qos classifers - #1526
Add "sequence-id" attribute for each term in qos classifers #1526PranavAdityaCP wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds a sequence-id leaf to the QoS classifier term grouping in openconfig-qos-elements.yang to define the matching order of terms. The review feedback identifies a minor grammatical typo in the description of the new leaf and provides a suggestion to correct it.
| leaf sequence-id { | ||
| type uint32; | ||
| description | ||
| "The sequence id determines the order in which terms | ||
| are matched. The sequence id must be unique for each entry | ||
| in terms. Target devices should apply the terms | ||
| in ascending order determined by sequence id (low to | ||
| high), rather than the relying only on order in the list."; | ||
| } |
There was a problem hiding this comment.
There is a grammatical typo in the description of the sequence-id leaf: "rather than the relying only on order in the list." should be "rather than relying only on the order in the list."
| leaf sequence-id { | |
| type uint32; | |
| description | |
| "The sequence id determines the order in which terms | |
| are matched. The sequence id must be unique for each entry | |
| in terms. Target devices should apply the terms | |
| in ascending order determined by sequence id (low to | |
| high), rather than the relying only on order in the list."; | |
| } | |
| leaf sequence-id { | |
| type uint32; | |
| description | |
| "The sequence id determines the order in which terms | |
| are matched. The sequence id must be unique for each entry | |
| in terms. Target devices should apply the terms | |
| in ascending order determined by sequence id (low to | |
| high), rather than relying only on the order in the list."; | |
| } |
Change Scope
Currently the terms in
qos/classifersdo not have any clear way based on which it can be ordered . Each term has a set of match conditions and an associated action and we could have multiple terms within a classifier, however it is not clear how to order the terms (in case the terms have overlapping match criteria, the order would determine the term and action that gets applied).Please refer the open issue : #1387
Hence to address this requirement we are adding sequence-id as a new leaf under the paths
Note : It is backward compatible as it is a new leaf and NOT a key node
Tree View