Adding list leaf for SSH public keys #1498
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -420,6 +420,23 @@ module openconfig-aaa { | |||||
| description | ||||||
| "Operational state data for local users"; | ||||||
| } | ||||||
|
|
||||||
| grouping authorized-ssh-key-config { | ||||||
| description | ||||||
| "Configuration data for user SSH keys"; | ||||||
|
|
||||||
| leaf key-name { | ||||||
|
syaghi-c marked this conversation as resolved.
Outdated
|
||||||
| type string; | ||||||
| description | ||||||
| "The name with which to reference the authorized SSH public key"; | ||||||
| } | ||||||
|
|
||||||
| leaf authorized-ssh-key { | ||||||
|
Contributor
There was a problem hiding this comment. Nomenclature-wise, would suggest key/public-key vs. "authorized-ssh-key" throughout - This also replicated the list name as a child |
||||||
| type string; | ||||||
|
Contributor
There was a problem hiding this comment. Ref to credentialz decomposition: https://github.com/openconfig/gnsi/blob/main/credentialz/credentialz.proto#L445-L461 |
||||||
| description | ||||||
| "Authorized SSH public key for the user (RSA or ECDSA)"; | ||||||
|
syaghi-c marked this conversation as resolved.
Outdated
|
||||||
| } | ||||||
| } | ||||||
|
|
||||||
| grouping aaa-authentication-user-top { | ||||||
| description | ||||||
|
|
@@ -458,6 +475,38 @@ module openconfig-aaa { | |||||
| uses aaa-authentication-user-config; | ||||||
| uses aaa-authentication-user-state; | ||||||
| } | ||||||
|
|
||||||
| container authorized-ssh-keys { | ||||||
|
Contributor
There was a problem hiding this comment. Suggest putting this into a grouping rather and outside of this grouping |
||||||
| description | ||||||
| "Top-level container for authorized SSH keys"; | ||||||
|
|
||||||
| list authorized-ssh-key { | ||||||
| key "key-name"; | ||||||
| description | ||||||
| "Authorized SSH public keys for the user (RSA or ECDSA)"; | ||||||
|
|
||||||
|
|
||||||
| leaf key-name { | ||||||
| type leafref { | ||||||
| path "../config/key-name"; | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
| description | ||||||
| "References the key name in the configuration block"; | ||||||
| } | ||||||
|
|
||||||
| container config { | ||||||
| description | ||||||
| "Configuration data for the authorized SSH key"; | ||||||
| uses authorized-ssh-key-config; | ||||||
| } | ||||||
|
|
||||||
| container state { | ||||||
| config false; | ||||||
| description | ||||||
| "Operational state data for the authorized SSH key"; | ||||||
| uses authorized-ssh-key-config; | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| } | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: check your whitespace + spaces vs. tabs - github UI doesn't help for this