Skip to content

Support for RPC, Actions and Notifications when generating Paths #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siva19susi wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support for RPC, Actions and Notifications when generating Paths #531

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ae6e20
support for rpc & action - draft1
Jun 25, 2024
a8c14f6
support for notification
Jun 26, 2024
97f1424
cleanup fmt.Println
Jun 26, 2024
d02ed90
isRpc isAction isNotification
Jun 26, 2024
e963fe8
Merge branch 'openconfig:main' into main
siva19susi Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions pkg/app/path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ type generatedPath struct {
IsState bool `json:"is-state,omitempty"`
Namespace string `json:"namespace,omitempty"`
FeatureList []string `json:"if-features,omitempty"`
IsNotification bool `json:"is-notification,omitempty"`
IsRpc bool `json:"is-rpc,omitempty"`
IsAction bool `json:"is-action,omitempty"`
}

func (a *App) PathCmdRun(d, f, e []string, pgo pathGenOpts) error {
Expand Down Expand Up @@ -234,6 +237,33 @@ func collectSchemaNodes(e *yang.Entry, leafOnly bool) []*yang.Entry {
collectSchemaNodes(child, leafOnly)...)
}

// Support for Notification
if e.Node.Kind() == "notification" {
if e.Extra == nil {
e.Extra = make(map[string][]interface{})
}
e.Extra["notification"] = []interface{}{true}
}

// Support for RPC & Action
if e.RPC != nil {
kind := e.Node.Kind()
if e.RPC.Input != nil {
if e.RPC.Input.Extra == nil {
e.RPC.Input.Extra = make(map[string][]interface{})
}
e.RPC.Input.Extra[kind] = []interface{}{true}
collected = append(collected, collectSchemaNodes(e.RPC.Input, leafOnly)...)
}
if e.RPC.Output != nil {
if e.RPC.Output.Extra == nil {
e.RPC.Output.Extra = make(map[string][]interface{})
}
e.RPC.Output.Extra[kind] = []interface{}{true}
collected = append(collected, collectSchemaNodes(e.RPC.Output, leafOnly)...)
}
}

if e.Parent != nil {
switch {
case e.Dir == nil && e.ListAttr != nil: // leaf-list
Expand Down Expand Up @@ -291,6 +321,30 @@ func collectSchemaNodes(e *yang.Entry, leafOnly bool) []*yang.Entry {
}
}
}
// Support for Notification
if len(e.Extra["notification"]) > 0 {
for _, myleaf := range collected {
if myleaf.Extra["notification"] == nil {
myleaf.Extra["notification"] = e.Extra["notification"]
}
}
}
// Support for RPC
if len(e.Extra["rpc"]) > 0 {
for _, myleaf := range collected {
if myleaf.Extra["rpc"] == nil {
myleaf.Extra["rpc"] = e.Extra["rpc"]
}
}
}
// Support for Action
if len(e.Extra["action"]) > 0 {
for _, myleaf := range collected {
if myleaf.Extra["action"] == nil {
myleaf.Extra["action"] = e.Extra["action"]
}
}
}
}
}
return collected
Expand Down Expand Up @@ -334,6 +388,19 @@ func (a *App) generatePath(entry *yang.Entry, pType string) *generatedPath {
}
}

// Support for Notification
if len(entry.Extra["notification"]) == 1 {
gp.IsNotification = true
}
// Support for RPC
if len(entry.Extra["rpc"]) == 1 {
gp.IsRpc = true
}
// Support for Action
if len(entry.Extra["action"]) == 1 {
gp.IsAction = true
}

gp.Description = entry.Description
if entry.Type != nil {
gp.Type = entry.Type.Name
Expand Down