DP-1.5: Egress Strict Priority scheduler with bursty traffic - #5812
DP-1.5: Egress Strict Priority scheduler with bursty traffic#5812mihaitomaro wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the test metadata for the Egress Strict Priority scheduler with bursty traffic by disabling the interface_output_queue_non_standard_name deviation, ensuring the test aligns with current platform expectations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5812 / 2e8c188Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the metadata textproto file for the egress strict priority scheduler test by setting the deviation interface_output_queue_non_standard_name to false. The reviewer suggested removing this line entirely because false is the default value for boolean fields in protobuf, making the explicit setting redundant.
Set interface_output_queue_non_standard_name deviation to false