Skip to content

Add RT-5.17: Physical Interface Drain via Admin Down test with ISIS and BGP in place specification - #5808

Open
navaneethyv wants to merge 3 commits into
mainfrom
feature/rt-5.17-interface-admin-drain
Open

Add RT-5.17: Physical Interface Drain via Admin Down test with ISIS and BGP in place specification#5808
navaneethyv wants to merge 3 commits into
mainfrom
feature/rt-5.17-interface-admin-drain

Conversation

@navaneethyv

Copy link
Copy Markdown
Contributor

PR DESCRIPTION:
This pull request introduces the new test specification and configuration for RT-5.17: Physical Interface Drain via Admin Down.

Summary
This test specification validates that administratively disabling a physical interface (enabled = false) via gNMI:

  1. Triggers clean teardowns of associated routing protocol sessions (BGP peering sessions and IS-IS Level-2 adjacencies).
  2. Ceases all traffic forwarding across the drained physical interface.
  3. Ensures pass-through traffic across non-drained interfaces remains completely unaffected.
  4. Restores routing sessions and traffic forwarding successfully once the interface is re-enabled (enabled = true).

@navaneethyv
navaneethyv requested review from a team as code owners July 30, 2026 12:31
@navaneethyv
navaneethyv requested a review from rohit-rp July 30, 2026 12:31
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test specification, RT-5.17, designed to verify the behavior of physical interfaces when administratively disabled via gNMI. The test confirms that the control plane (BGP/IS-IS) and data plane react appropriately by tearing down sessions and stopping traffic, and that these services recover seamlessly once the interface is re-enabled. This ensures robust network management and stability during maintenance operations.

Highlights

  • New Test Specification: Added a new test specification (RT-5.17) to validate physical interface draining via administrative down status.
  • Routing Protocol Validation: The test ensures that BGP and IS-IS sessions tear down cleanly when an interface is disabled and restore correctly upon re-enabling.
  • Traffic Isolation: Verified that traffic forwarding ceases on the drained interface while pass-through traffic on other interfaces remains unaffected.
  • Registry Update: Registered the new test case in the testregistry.textproto file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@navaneethyv
navaneethyv requested a review from AmrNJ July 30, 2026 12:31
@OpenConfigBot

OpenConfigBot commented Jul 30, 2026

Copy link
Copy Markdown

@navaneethyv navaneethyv added the systemTest Systematic Iron gate test plan label Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test plan, RT-5.17: Physical Interface Drain via Admin Down, which includes a detailed README, metadata, and registration in the test registry. The review feedback suggests improving the test documentation by explicitly specifying the Network Instance (VRF) assignment (e.g., DEFAULT) for all interfaces in both the topology description and the setup procedure to ensure clarity.

Comment thread feature/interface/singleton/otg_tests/interface_admin_drain_test/README.md Outdated
Comment thread feature/interface/singleton/otg_tests/interface_admin_drain_test/README.md Outdated
navaneethyv and others added 2 commits July 30, 2026 18:03
…st/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…st/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

systemTest Systematic Iron gate test plan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants