Addition of a Shadow Go Static Check which is 75% faster than the existing Check Saving 35mins per run

.github/workflows/go.yml

@@ -1,4 +1,4 @@
 name: Go
 
 on:
   push:
@@ -7,10 +7,10 @@
   schedule:
     - cron: "0 0 * * *"
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
     # Go & staticcheck build cache require a lot of disk space.  Reclaim extra
     # space for the container by removing unnecessary tooling.
     - name: Free additional disk space
@@ -19,24 +19,20 @@
         sudo rm -rf /usr/local/lib/android
         sudo rm -rf /opt/hostedtoolcache/CodeQL
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
         go-version-file: 'go.mod'
         cache: true
-    - name: Move cache
-      run: |
-        sudo mv "${HOME}/.cache" /mnt/cache
-        ln -s /mnt/cache "${HOME}/.cache"
     # Dependency for Go module github.com/google/gopacket
     - name: Install libpcap-dev
       run: sudo apt-get -y install libpcap-dev
     - name: Build
       run: go build -v ./...
 
   test:
     runs-on: ubuntu-latest
     steps:    
       - uses: actions/checkout@v4
       # Go & staticcheck build cache require a lot of disk space.  Reclaim extra
       # space for the container by removing unnecessary tooling.
       - name: Free additional disk space
@@ -45,14 +41,10 @@
           sudo rm -rf /usr/local/lib/android
           sudo rm -rf /opt/hostedtoolcache/CodeQL
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
           go-version-file: 'go.mod'
           cache: true
-      - name: Move cache
-        run: |
-          sudo mv "${HOME}/.cache" /mnt/cache
-          ln -s /mnt/cache "${HOME}/.cache"
       # Dependency for Go module github.com/google/gopacket
       - name: Install libpcap-dev
         run: sudo apt-get -y install libpcap-dev
@@ -63,63 +55,93 @@
         with:
           path-to-profile: profile.cov
 
-  static_analysis:
-    name: Static Analysis
+  fast_analysis:
+    name: Fast Analysis
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
     - name: Free additional disk space
       run: |
         sudo rm -rf /usr/share/dotnet
         sudo rm -rf /usr/local/lib/android
         sudo rm -rf /opt/hostedtoolcache/CodeQL
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
         go-version-file: 'go.mod'
         cache: true
-    - name: Move cache
-      run: |
-        sudo mv "${HOME}/.cache" /mnt/cache
-        ln -s /mnt/cache "${HOME}/.cache"
     # Dependency for Go module github.com/google/gopacket
     - name: Install libpcap-dev
       run: sudo apt-get -y install libpcap-dev
 
-    # === THIS IS THE ONLY CHANGE ===
-    - name: Clean Go build cache before analysis
-      run: go clean -cache
-    # ===============================
-
     - name: Go vet
       run: GOGC=30 go vet ./...
     - name: Gofmt
       run: |
-        # gofmt always returns true, so we use grep '^' which returns
-        # true on non-empty output, but will otherwise passthrough all
-        # output lines.
-        if gofmt -d -s . | grep '^'; then
+        # Use find to exclude generated pb.go files which take too long to parse
+        unformatted=$(find . -name "*.go" -type f | grep -v "pb.go$" | xargs gofmt -d -s)
+        if [ -n "$unformatted" ]; then
+          echo "$unformatted"
           exit 1
         fi
     - name: Get goimports
       run: go install golang.org/x/tools/cmd/goimports@latest
     - name: Goimports
       run: |
-        # goimports always returns true, so we use grep '^' which returns
-        # true on non-empty output, but will otherwise passthrough all
-        # output lines.
-        #
-        # goimports does not support "gofmt -s" so both goimports and gofmt are
-        # required.
-        find . -name "*.go" | egrep -v "pb.go$" | while read l; do
-          if goimports -d $l | grep '^'; then
-            exit 1;
-          fi;
-        done
+        # goimports does not support "gofmt -s" so both goimports and gofmt are required.
+        unformatted=$(find . -name "*.go" -type f | grep -v "pb.go$" | xargs goimports -l)
+        if [ -n "$unformatted" ]; then
+          echo "The following files have goimports formatting errors:"
+          echo "$unformatted"
+          exit 1
+        fi
     - name: Get revive
       run: go install github.com/mgechev/revive@v1.3.4
     - name: Run revive
       run: revive ./...
+
+    - name: Get changed Go directories
+      id: changed-dirs
+      if: github.event_name == 'pull_request'
+      uses: tj-actions/changed-files@v44
+      with:
+        files: |
+          **/*.go
+        dir_names: true
+
+    - name: Get staticcheck
+      if: github.event_name == 'pull_request' && steps.changed-dirs.outputs.any_changed == 'true'
+      run: go install honnef.co/go/tools/cmd/staticcheck@latest
+
+    - name: Run staticcheck on changed packages
+      if: github.event_name == 'pull_request' && steps.changed-dirs.outputs.any_changed == 'true'
+      run: |
+        for dir in ${{ steps.changed-dirs.outputs.all_changed_files }}; do
+          echo "Running staticcheck on ./$dir/..."
+          GOGC=30 staticcheck "./$dir/..."
+        done
+
+  deep_analysis:
+    name: Deep Analysis (Staticcheck)
+    # Only run on cron schedule or push to main, NOT on pull requests
+    if: github.event_name != 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Free additional disk space
+      run: |
+        sudo rm -rf /usr/share/dotnet
+        sudo rm -rf /usr/local/lib/android
+        sudo rm -rf /opt/hostedtoolcache/CodeQL
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version-file: 'go.mod'
+        cache: true
+    # Dependency for Go module github.com/google/gopacket
+    - name: Install libpcap-dev
+      run: sudo apt-get -y install libpcap-dev
+
     - name: Get staticcheck
       run: go install honnef.co/go/tools/cmd/staticcheck@latest
     - name: Run staticcheck

feature/platform/transceiver/tests/zrp_laser_bias_current_test/zrp_laser_bias_current_test.go

@@ -51,8 +51,8 @@ func TestMain(m *testing.M) {
 
 func verifyLaserBiasValue(t *testing.T, laserBiasValue float64) {
 	t.Helper()
-	if laserBiasValue <= 0 && laserBiasValue >= 131 {
-		t.Errorf("The laser bias value is not between 0 and 131")
+	if laserBiasValue < 0.0 || laserBiasValue > 131.0 {
+		t.Errorf("The laser bias value %f is not between 0 and 131", laserBiasValue)
 	}
 }
 
@@ -67,7 +67,7 @@ func verifyLaserBiasCurrentAll(t *testing.T, p1Stream *samplestream.SampleStream
 	}
 	laserBiasInstant := laserBiasVal.GetInstant()
 	if reflect.TypeOf(laserBiasInstant).Kind() != reflect.Float64 {
-		t.Fatalf("Return value is not type string")
+		t.Fatalf("Return value is not type float64")
 	}
 	t.Logf("laserBias Instant value: %f", laserBiasInstant)
 	if deviations.MissingZROpticalChannelTunableParametersTelemetry(dut1) {
@@ -81,7 +81,7 @@ func verifyLaserBiasCurrentAll(t *testing.T, p1Stream *samplestream.SampleStream
 		t.Logf("laserBias Max value: %f", laserBiasMax)
 		laserBiasAvg := laserBiasVal.GetAvg()
 		verifyLaserBiasValue(t, laserBiasAvg)
-		t.Logf("laserBias Avg value: %f", laserBiasMin)
+		t.Logf("laserBias Avg value: %f", laserBiasAvg)
 		if laserBiasAvg >= laserBiasMin && laserBiasAvg <= laserBiasMax {
 			t.Logf("The average %f is between the maximum and minimum values", laserBiasAvg)
 		} else {
@@ -144,8 +144,8 @@ func TestZRLaserBiasCurrentStateInterfaceFlap(t *testing.T) {
 	// Wait 120 sec cooling-off period
 	gnmi.Await(t, dut1, gnmi.OC().Interface(dp1.Name()).OperStatus().State(), intUpdateTime, oc.Interface_OperStatus_DOWN)
 	t.Logf("%v operational status is: %v", dp1.Name(), gnmi.Get(t, dut1, gnmi.OC().Interface(dp1.Name()).OperStatus().State()))
-	t.Log("Wait to update telemetry")
-	time.Sleep(80 * time.Second)
+	t.Log("Wait for laser bias current to update to 0.0")
+	gnmi.Await(t, dut1, component.OpticalChannel().LaserBiasCurrent().Instant().State(), 2*time.Minute, 0.0)
 	verifyLaserBiasCurrentAll(t, p1Stream, dut1)
 	// Enable interface
 	cfgplugins.ToggleInterface(t, dut1, dp1.Name(), true)