Fix ACCTZ-1.1 and ACCTZ-2.1 fail gRPC auth regression

[nkrishk]

Summary

Fixes ACCTZ-1.1 (record_subscribe_full) and ACCTZ-2.1 (record_subscribe_partial) failures on Cisco IOS-XR caused by a regression in fail gRPC RPC handling.

PR #5309 changed fail gRPC calls to use failPassword ("baggins"), which is the same password Credentialz configures on the DUT for user bilbo. As a result, fail RPCs authenticated successfully and acctz recorded AUTHZ_STATUS_PERMIT instead of the expected AUTHZ_STATUS_DENY.

This change restores the prior behavior:

• Use failAuthenticatePassword ("bagginsTest123!") for fail gRPC RPCs on non-Arista platforms so authentication fails as intended.
• Add logExpectedFailGRPCError() for vendor-specific error validation:
  • Arista: expect codes.PermissionDenied (authorization deny via failauthuser)
  • Cisco and others: accept any RPC error from bad credentials (e.g. Unauthenticated)

Root cause

	Before #5309 (pass)	After #5309 (fail)
Fail gRPC password	"bagginsTest123!"	"baggins" (matches DUT)
RPC result	Unauthenticated	RPC succeeds
Acctz authz status	DENY	PERMIT

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression in gRPC authentication testing that caused authorization failures on Cisco IOS-XR devices. By reverting to the correct test password and implementing a more flexible error validation mechanism, the changes ensure that authentication-based tests correctly identify denied access across different vendor platforms.

Highlights

• Authentication Password Correction: Updated fail gRPC RPCs to use failAuthenticatePassword instead of failPassword to ensure authentication fails as intended on non-Arista platforms.
• New Error Validation Helper: Introduced logExpectedFailGRPCError() to handle vendor-specific gRPC error validation, ensuring Arista platforms expect PermissionDenied while others accept any RPC error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5796 / c6ec301

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request refactors the acctz package by correcting password variable assignments and consolidating repetitive gRPC error-checking logic into a new helper function, logExpectedFailGRPCError. The review feedback correctly identifies a critical issue in this helper: for non-Arista platforms, if a gRPC call unexpectedly succeeds with bad credentials (i.e., err is nil), the helper only logs the event instead of failing the test. This would allow tests to silently pass despite authentication failures. A code suggestion has been provided to change this to a test error.