RT-2.1: Register missing ISIS protocol afi-safi and interface enabled telemetry state paths

[devansh-lodha]

Fixes #5793.

• (M) feature/isis/otg_tests/base_adjacencies_test/README.md
  • Add /network-instances/network-instance/protocols/protocol/isis/interfaces/interface/state/enabled
  • Add /network-instances/network-instance/protocols/protocol/isis/interfaces/interface/afi-safi/af/state/enabled
  • Add /network-instances/network-instance/protocols/protocol/isis/global/afi-safi/af/state/enabled
  • Add valid non-empty ISIS Canonical OC JSON

[OpenConfigBot]

Pull Request Functional Test Report for #5794 / fadf20b

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-2.1: Base IS-IS Process and Adjacencies
Cisco 8000E		RT-2.1: Base IS-IS Process and Adjacencies
Cisco XRd		RT-2.1: Base IS-IS Process and Adjacencies
Juniper ncPTX		RT-2.1: Base IS-IS Process and Adjacencies
Nokia SR Linux		RT-2.1: Base IS-IS Process and Adjacencies
Openconfig Lemming		RT-2.1: Base IS-IS Process and Adjacencies

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-2.1: Base IS-IS Process and Adjacencies
Cisco 8808		RT-2.1: Base IS-IS Process and Adjacencies
Juniper PTX10008		RT-2.1: Base IS-IS Process and Adjacencies
Nokia 7250 IXR-10e		RT-2.1: Base IS-IS Process and Adjacencies

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for the ISIS base adjacencies test. It ensures that specific telemetry state paths are correctly registered and provides a reference for the expected Canonical OpenConfig JSON structure, improving test clarity and coverage documentation.

Highlights

• Telemetry Path Coverage: Added missing ISIS protocol afi-safi and interface enabled telemetry state paths to the documentation.
• Canonical OC JSON: Included a valid non-empty ISIS Canonical OpenConfig JSON snippet to the test documentation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the ISIS base adjacencies test documentation by adding a Canonical OC JSON representation and expanding the list of covered state paths. The reviewer noted that the Canonical OC JSON is missing the interface configuration and recommended adding a representative interface configuration, as well as explicitly specifying the Network Instance (VRF) assignment for all interfaces to ensure clarity.