gNMI-1.21: Register missing integrated-circuit resource utilization telemetry paths - #5792
Conversation
Pull Request Functional Test Report for #5792 / e17f79eVirtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation and path coverage for integrated-circuit resource utilization telemetry. By registering additional OpenConfig paths and providing a canonical JSON example, it ensures better alignment with gNMI standards and improves the clarity of test requirements for hardware resource monitoring. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the integrated circuit utilization test. It adds a 'Canonical OC' section with a JSON example of the system utilization configuration and expands the list of covered OpenConfig paths to include several integrated-circuit utilization state paths (such as free, max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded). There are no review comments, and I have no feedback to provide.
Fixes #5791