RT-6.1: Register missing LLDP system-description and port-id-type telemetry paths

[devansh-lodha]

Fixes #5789.

• (M) feature/lldp/otg_tests/core_lldp_tlv_population_test/README.md
  • Add /lldp/interfaces/interface/neighbors/neighbor/state/port-id-type.
  • Add /lldp/state/system-description.
  • Add valid non-empty LLDP Canonical OC JSON.

[OpenConfigBot]

Pull Request Functional Test Report for #5790 / b93beed

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-6.1: Core LLDP TLV Population
Cisco 8000E		RT-6.1: Core LLDP TLV Population
Cisco XRd		RT-6.1: Core LLDP TLV Population
Juniper ncPTX		RT-6.1: Core LLDP TLV Population
Nokia SR Linux		RT-6.1: Core LLDP TLV Population
Openconfig Lemming		RT-6.1: Core LLDP TLV Population

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-6.1: Core LLDP TLV Population
Cisco 8808		RT-6.1: Core LLDP TLV Population
Juniper PTX10008		RT-6.1: Core LLDP TLV Population
Nokia 7250 IXR-10e		RT-6.1: Core LLDP TLV Population

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for the core LLDP TLV population test to ensure comprehensive coverage of telemetry paths. By registering missing paths and providing a canonical JSON example, the changes improve the accuracy and maintainability of the test suite's reference documentation.

Highlights

• Telemetry Path Registration: Registered missing LLDP telemetry paths for port-id-type and system-description in the test documentation.
• Canonical OC JSON Addition: Added a valid non-empty LLDP Canonical OpenConfig JSON snippet to the test README to improve documentation and test clarity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the README.md for the core LLDP TLV population test by adding a 'Canonical OC' section with a sample JSON configuration for OpenConfig interfaces and LLDP. It also expands the OpenConfig Path and RPC Coverage section to include paths for /lldp/interfaces/interface/neighbors/neighbor/state/port-id-type and /lldp/state/system-description. There are no review comments, and I have no feedback to provide.