Skip to content

TR-6.2: Add console, VTY, and file logging telemetry state paths to README - #5788

Open
devansh-lodha wants to merge 4 commits into
openconfig:mainfrom
devansh-lodha:fix/console-vty-logging-telemetry
Open

TR-6.2: Add console, VTY, and file logging telemetry state paths to README#5788
devansh-lodha wants to merge 4 commits into
openconfig:mainfrom
devansh-lodha:fix/console-vty-logging-telemetry

Conversation

@devansh-lodha

@devansh-lodha devansh-lodha commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #5787.

  • (M) feature/system/logging/otg_tests/console_vty_file/README.md
    • Add /system/logging/console/selectors/selector/state/severity.
    • Add Config Paths and State Paths YAML headers.
    • Add valid non-empty System Logging Canonical OC JSON.

…EADME

* (M) feature/system/logging/otg_tests/console_vty_file/README.md
  - Add /system/logging/console/selectors/selector/state/facility.
  - Add /system/logging/console/selectors/selector/state/severity.
  - Add /system/logging/vty/selectors/selector/state/facility.
  - Add /system/logging/vty/selectors/selector/state/severity.
  - Add /system/logging/files/file/selectors/selector/state/facility.
  - Add /system/logging/files/file/selectors/selector/state/severity.
  - Add /system/logging/files/file/state/rotate.
  - Add Config Paths and State Paths YAML headers.
  - Add valid non-empty System Logging Canonical OC JSON.
… CSV line 344

* (M) feature/system/logging/otg_tests/console_vty_file/README.md
  - Add /system/logging/console/selectors/selector/state/severity (Catalog CSV Line 344).
  - Include valid non-empty System Logging Canonical OC JSON.
@devansh-lodha
devansh-lodha requested a review from a team as a code owner July 29, 2026 06:38
@OpenConfigBot

OpenConfigBot commented Jul 29, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5788 / 7e4b013

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TR-6.2: Local logging destinations
Cisco 8000E status
TR-6.2: Local logging destinations
Cisco XRd status
TR-6.2: Local logging destinations
Juniper ncPTX status
TR-6.2: Local logging destinations
Nokia SR Linux status
TR-6.2: Local logging destinations
Openconfig Lemming status
TR-6.2: Local logging destinations

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TR-6.2: Local logging destinations
Cisco 8808 status
TR-6.2: Local logging destinations
Juniper PTX10008 status
TR-6.2: Local logging destinations
Nokia 7250 IXR-10e status
TR-6.2: Local logging destinations

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #5787 by enhancing the documentation for system logging telemetry. It ensures that the README accurately reflects the available configuration and state paths for console, VTY, and file logging, while providing a concrete JSON example for Canonical OpenConfig implementation.

Highlights

  • Documentation Update: Updated the README to include missing telemetry state paths for console, VTY, and file logging.
  • Structural Improvements: Added clear headers for Config and State paths to improve readability of the YAML documentation.
  • Canonical OC JSON: Included a valid, non-empty System Logging Canonical OpenConfig JSON example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test README.md by organizing the paths into 'Config Paths' and 'State Paths', adding a state path for console logging severity, and introducing a 'Canonical OC' JSON example. The reviewer identified that the 'Canonical OC' JSON structure is incorrect because OpenConfig requires configurable leaves like 'facility' and 'severity' to reside within a 'config' container under the list element, and provided the corrected JSON structure.

Comment thread feature/system/logging/otg_tests/console_vty_file/README.md
…ner per code review

* (M) feature/system/logging/otg_tests/console_vty_file/README.md
  - Wrap facility and severity inside config container under selector list item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TR-6.2: Missing console logging severity telemetry path in README.md

2 participants