TR-6.2: Add console, VTY, and file logging telemetry state paths to README - #5788
TR-6.2: Add console, VTY, and file logging telemetry state paths to README#5788devansh-lodha wants to merge 4 commits into
Conversation
…EADME * (M) feature/system/logging/otg_tests/console_vty_file/README.md - Add /system/logging/console/selectors/selector/state/facility. - Add /system/logging/console/selectors/selector/state/severity. - Add /system/logging/vty/selectors/selector/state/facility. - Add /system/logging/vty/selectors/selector/state/severity. - Add /system/logging/files/file/selectors/selector/state/facility. - Add /system/logging/files/file/selectors/selector/state/severity. - Add /system/logging/files/file/state/rotate. - Add Config Paths and State Paths YAML headers. - Add valid non-empty System Logging Canonical OC JSON.
… CSV line 344 * (M) feature/system/logging/otg_tests/console_vty_file/README.md - Add /system/logging/console/selectors/selector/state/severity (Catalog CSV Line 344). - Include valid non-empty System Logging Canonical OC JSON.
Pull Request Functional Test Report for #5788 / 7e4b013Virtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #5787 by enhancing the documentation for system logging telemetry. It ensures that the README accurately reflects the available configuration and state paths for console, VTY, and file logging, while providing a concrete JSON example for Canonical OpenConfig implementation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the test README.md by organizing the paths into 'Config Paths' and 'State Paths', adding a state path for console logging severity, and introducing a 'Canonical OC' JSON example. The reviewer identified that the 'Canonical OC' JSON structure is incorrect because OpenConfig requires configurable leaves like 'facility' and 'severity' to reside within a 'config' container under the list element, and provided the corrected JSON structure.
…ner per code review * (M) feature/system/logging/otg_tests/console_vty_file/README.md - Wrap facility and severity inside config container under selector list item.
Fixes #5787.