Skip to content

RT-1.5: Add standard neighbor prefix-limit state paths to README - #5786

Open
devansh-lodha wants to merge 3 commits into
openconfig:mainfrom
devansh-lodha:fix/bgp-prefix-limit-standard-telemetry
Open

RT-1.5: Add standard neighbor prefix-limit state paths to README#5786
devansh-lodha wants to merge 3 commits into
openconfig:mainfrom
devansh-lodha:fix/bgp-prefix-limit-standard-telemetry

Conversation

@devansh-lodha

Copy link
Copy Markdown
Contributor
  • (M) feature/bgp/prefixlimit/otg_tests/bgp_prefix_limit_test/README.md
    • Add standard non-deviation /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/state/prefix-limit-exceeded.
    • Add standard non-deviation /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/state/warning-threshold-pct.
    • Add standard non-deviation /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/state/prefix-limit-exceeded.
    • Add standard non-deviation /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/state/warning-threshold-pct.
    • Add Config Paths and State Paths YAML headers.

* (M) feature/bgp/prefixlimit/otg_tests/bgp_prefix_limit_test/README.md
  - Add standard non-deviation /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/state/prefix-limit-exceeded.
  - Add standard non-deviation /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/state/warning-threshold-pct.
  - Add standard non-deviation /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/state/prefix-limit-exceeded.
  - Add standard non-deviation /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/state/warning-threshold-pct.
  - Add Config Paths and State Paths YAML headers.
@devansh-lodha
devansh-lodha requested a review from a team as a code owner July 29, 2026 06:04
@OpenConfigBot

OpenConfigBot commented Jul 29, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5786 / 2c247dc

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.5: BGP Prefix Limit
Cisco 8000E status
RT-1.5: BGP Prefix Limit
Cisco XRd status
RT-1.5: BGP Prefix Limit
Juniper ncPTX status
RT-1.5: BGP Prefix Limit
Nokia SR Linux status
RT-1.5: BGP Prefix Limit
Openconfig Lemming status
RT-1.5: BGP Prefix Limit

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.5: BGP Prefix Limit
Cisco 8808 status
RT-1.5: BGP Prefix Limit
Juniper PTX10008 status
RT-1.5: BGP Prefix Limit
Nokia 7250 IXR-10e status
RT-1.5: BGP Prefix Limit

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for BGP prefix limit testing by adding missing state paths and organizing the existing YAML configuration block. These changes ensure that the documentation accurately reflects the supported paths for neighbor prefix-limit monitoring.

Highlights

  • Documentation Update: Added standard non-deviation BGP neighbor prefix-limit state paths for both IPv4 and IPv6 unicast.
  • YAML Organization: Introduced explicit 'Config Paths' and 'State Paths' headers to the README to improve readability and structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the BGP prefix limit OTG test to categorize OpenConfig paths into config and state sections, adding several new state paths. The reviewer recommended adding the missing BGP neighbor prefix-limit configuration paths under the config paths section to ensure complete coverage tracking and alignment with the test implementation.

Comment thread feature/bgp/prefixlimit/otg_tests/bgp_prefix_limit_test/README.md
… review feedback

* (M) feature/bgp/prefixlimit/otg_tests/bgp_prefix_limit_test/README.md
  - Add /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/config/max-prefixes.
  - Add /bgp/neighbors/neighbor/.../ipv4-unicast/prefix-limit/config/warning-threshold-pct.
  - Add /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/config/max-prefixes.
  - Add /bgp/neighbors/neighbor/.../ipv6-unicast/prefix-limit/config/warning-threshold-pct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants