PF-1.27.1 - MPLSoGRE Encap with MACsec and IMIX Traffic (Functional, 10G & 100G)

[sancheetaroy]

PF-1.27.1 - MPLSoGRE Encap with MACsec and IMIX Traffic (Functional, 10G & 100G)

Pass logs : https://fusion2.corp.google.com/invocations/cfa104be-72c4-4ed2-8a7c-9f2523137067

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new functional test suite to verify MPLSoGRE and MPLSoGUE encapsulation performance when used in conjunction with MACsec. The changes include necessary infrastructure updates to support Arista-specific TCAM profiles and native MACsec configuration, ensuring that policy forwarding and encapsulation features are correctly validated across different hardware platforms.

Highlights

• New Test Suite: Added a comprehensive test suite to validate MPLSoGRE and MPLSoGUE encapsulation over MACsec.
• TCAM Profile Updates: Implemented Arista-specific TCAM profiles to support Advanced Network Policy Forwarding (ANPF).
• MACsec Configuration: Added native MACsec configuration support for Arista devices to handle hardware-level security.
• Configuration Refinement: Updated static next-hop label stack values to ensure correct packet encapsulation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test for MPLSoGRE and MPLSoGUE MACsec functionality, along with supporting configuration updates in cfgplugins for ANPF hardware TCAM, MACsec, and static next-hops. The review feedback highlights several critical style guide violations that must be addressed: replacing static sleeps with gnmi.Watch to prevent pipeline slowness, registering state reversion via t.Cleanup(), ensuring neighbor resolution with otgutils.WaitForARP before starting traffic, updating IP addresses to use compliant RFC blocks, and removing unused constants.

[OpenConfigBot]

Pull Request Functional Test Report for #5785 / 7dce8cf

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	5b7b3af4	Log
Cisco 8000E		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	b446f964	Log
Cisco XRd		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	a54ece90	Log
Juniper ncPTX		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	dbb4863f	Log
Nokia SR Linux		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	7759c756	Log
Openconfig Lemming		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance	ec61b54c	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance
Cisco 8808		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance
Juniper PTX10008		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance
Nokia 7250 IXR-10e		PF-1.27: MPLSoGRE/MPLSoGUE MACsec and Line Rate Performance

Help