Fix credentialz tests and hiba cert path handling - #5768
Conversation
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #5768 / 4f206dbVirtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability and flexibility of credential testing within the OpenConfig feature profiles. It addresses intermittent failures in SSH authentication tests by implementing retry mechanisms and enhances the HIBA authentication test setup by allowing external configuration of certificate paths. Additionally, it fixes a bug in password rotation logic to ensure proper cleanup of credentials. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
dipchauh
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable directory (certsDir) for pre-generated HIBA CA keys and certificates, updates CreateHibaKeys to use this directory, and refactors RotateUserPassword to simplify credential rotation. Additionally, it adds a retry loop for SSH password authentication in host_certificates_test.go. Review feedback suggests failing fast with t.Fatalf if reading critical CA keys fails, and using ctx.Err() to idiomatically bound the SSH retry loop instead of manually tracking elapsed time.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
2 participants
host_certificates, consistent with other credentialz tests, so login can succeed after host certificate rotation.RotateUserPasswordto only set the Password field when a non-empty password is provided, so password deletion works correctly during cleanup.hiba_certs_dirflag tohiba_authentication_testso pre-generated HIBA keys/certs can be loaded from a configurable directory instead of the process CWD."This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."